feat(eslint-plugin-react-hooks): make flat config the recommended config
#32457
+91
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig This change swaps which config `recommended` is aliasing. In 5.2.0, the new flat config was introduced as `recommended-latest`, while `recommended` still pointed at the legacy rc-based config, with a note that in the next major version `recommended` would be updated to point at `recommend-latest`. This change makes that swap, and make the default `recommended` experience the flat config. To continue using the legacy rc recommended config, please make the following change in your config ```diff - extends: ['plugin:react-hooks/recommended'] + extends: ['plugin:react-hooks/recommended-legacy'] ``` This change also deprecates `recommended-latest` in favor of `recommended. `recommended-latest` will be removed in a future major version. BREAKING CHANGE
This change updates the README to prioritize flat config and updates the usage examples to reflect the change in recommended configs.
This change updates the eslint-v9 fixture to use a typescript config
|
Comparing: d55cc79...885e163 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
michaelfaith
commented
Feb 22, 2025
| "eslint-plugin-react-hooks": "link:../../build/oss-stable/eslint-plugin-react-hooks" | ||
| "eslint": "^9.18.0", | ||
| "eslint-plugin-react-hooks": "link:../../build/oss-stable/eslint-plugin-react-hooks", | ||
| "jiti": "^2.4.2" |
There was a problem hiding this comment.
jiti is what eslint uses for parsing ts configs. https://eslint.org/docs/latest/use/configure/configuration-files#typescript-configuration-files
github-actions bot
pushed a commit
that referenced
this pull request
Feb 28, 2025
…onfig (#32457) This change swaps which config `recommended` is aliasing. In 5.2.0, the new flat config was introduced as `recommended-latest`, while `recommended` still pointed at the legacy rc-based config, with a note that in the next major version `recommended` would be updated to point at `recommend-latest`. This change makes that swap, and make the default `recommended` experience the flat config. To continue using the legacy rc recommended config, please make the following change in your config ```diff - extends: ['plugin:react-hooks/recommended'] + extends: ['plugin:react-hooks/recommended-legacy'] ``` This change also deprecates `recommended-latest` in favor of `recommended`. `recommended-latest` will be removed in a future major version. The README has been updated to reflect the new usage, and to put the flat config sections before the legacy config sections. I also took the opportunity to change the v9 fixture to use a typescript config, serving as a demonstration for usage as well as a way to validate the types are correct. BREAKING CHANGE --------- Co-authored-by: lauren <poteto@users.noreply.github.com> DiffTrain build for [ca12911](ca12911)
This was referenced Mar 3, 2025
This was referenced Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change swaps which config
recommendedis aliasing. In 5.2.0, the new flat config was introduced asrecommended-latest, whilerecommendedstill pointed at the legacy rc-based config, with a note that in the next major versionrecommendedwould be updated to point atrecommend-latest. This change makes that swap, and make the defaultrecommendedexperience the flat config. To continue using the legacy rc recommended config, please make the following change in your configThis change also deprecates
recommended-latestin favor ofrecommended.recommended-latestwill be removed in a future major version.The README has been updated to reflect the new usage, and to put the flat config sections before the legacy config sections.
I also took the opportunity to change the v9 fixture to use a typescript config, serving as a demonstration for usage as well as a way to validate the types are correct.
BREAKING CHANGE