[Fizz] Add Node Web Streams bundle for SSR #33441
Merged
+557
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: 3705486...4735f9c Critical size changesIncludes critical production bundles, as well as any change greater than 2%: Significant size changesIncludes any change greater than 0.2%: Expand to show |
sebmarkbage
force-pushed
the
nodewebstream
branch
from
0655dbd to
393b2e9
Compare
sebmarkbage
force-pushed
the
nodewebstream
branch
from
393b2e9 to
4735f9c
Compare
sebmarkbage
commented
Jun 5, 2025
| export type BinaryChunk = Uint8Array; | ||
|
|
||
| export function scheduleWork(callback: () => void) { | ||
| setImmediate(callback); |
There was a problem hiding this comment.
This is a big one. The Edge build uses setTimeout which might not be as fast as setImmediate in Node but is in Edge environments.
sebmarkbage
added a commit
that referenced
this pull request
Jun 7, 2025
New take on #33441. This uses a wrapper instead of a separate bundle.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We highly recommend using Node Streams in Node.js because it's much faster and it is less likely to cause issues when chained in things like compression algorithms that need explicit flushing which the Web Streams ecosystem doesn't have a good solution for. However, that said, people want to be able to use the worse option for various reasons.
The
.edgebuilds aren't technically intended for Node.js. A Node.js environments needs to be patched in various ways to support it. It's also less optimal since it can't use Node.js exclusive features and have to use the lowest common denominator such as JS implementations instead of native.This adds a Web Streams build of Fizz but exclusively for Node.js so that in it we can rely on Node.js modules. The main difference compared to Edge is that SSR now uses
createHashfrom the"crypto"module and importsTextEncoderfrom"util". We usesetImmediateinstead ofsetTimeout.The public API is just
react-dom/serverwhich in Node.js automatically importsreact-dom/server.nodewhich re-exports the legacy bundle, Node Streams bundle and Node Web Streams bundle. The main downside is if your bundler isn't smart to DCE this barrel file.With Flight the difference is larger but that's a bigger lift.