[Fizz] Name content inside "Suspense fallback" #33723
Merged
+74
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
approved these changes
Jul 7, 2025
| } | ||
| return createComponentStackFromType( | ||
| componentStack.parent, | ||
| 'Suspense Fallback', |
There was a problem hiding this comment.
I guess we can't get the actual type from props because it could be a lazy node?
There was a problem hiding this comment.
The issue is that the real type is modeled as a symbol. However, we don't have a symbol for the fallback case. So I just gave it a string name since in practice we format them the same as built-ins.
sebmarkbage
force-pushed
the
suspensefallbackstack
branch
from
6e1caf1 to
c8da2e9
Compare
sebmarkbage
added a commit
that referenced
this pull request
Jul 8, 2025
Same as #33723 but for Fiber.
This was referenced Jul 8, 2025
This was referenced Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content in Suspense fallbacks are really not considered part of the Suspense but since it does have some behavior it should be marked somehow separately from the Suspense content.
A follow up would be to do the same in Fiber.