KEMBAR78
[flags] enable opt-in for enableDefaultTransitionIndicator by rickhanlonii · Pull Request #34373 · facebook/react · GitHub
Skip to content

[flags] enable opt-in for enableDefaultTransitionIndicator #34373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

[flags] enable opt-in for enableDefaultTransitionIndicator #34373

merged 1 commit into from
Sep 3, 2025

Conversation

rickhanlonii
Copy link
Member

So we can test the feature.

@meta-cla meta-cla bot added the CLA Signed label Sep 3, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Sep 3, 2025
@react-sizebot
Copy link

react-sizebot commented Sep 3, 2025 •
edited
Loading

Comparing: ac3e705...cf5cb8c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.31 kB 530.31 kB = 93.39 kB 93.39 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 657.78 kB 657.78 kB = 115.66 kB 115.66 kB
facebook-www/ReactDOM-prod.classic.js +0.61% 677.76 kB 681.91 kB +0.63% 118.94 kB 119.69 kB
facebook-www/ReactDOM-prod.modern.js +0.62% 668.19 kB 672.34 kB +0.63% 117.26 kB 118.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js +1.18% 337.72 kB 341.72 kB +1.20% 58.48 kB 59.18 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +1.10% 362.51 kB 366.50 kB +1.12% 61.91 kB 62.60 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js +1.02% 387.98 kB 391.93 kB +1.00% 66.87 kB 67.55 kB
react-native/implementations/ReactFabric-prod.fb.js +1.00% 381.56 kB 385.39 kB +0.98% 65.96 kB 66.60 kB
facebook-www/ReactART-prod.modern.js +0.98% 374.17 kB 377.85 kB +1.08% 62.69 kB 63.37 kB
facebook-www/ReactART-prod.classic.js +0.96% 384.01 kB 387.69 kB +1.08% 64.29 kB 64.98 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-prod.js +0.90% 581.05 kB 586.31 kB +0.79% 102.14 kB 102.95 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-prod.js +0.90% 586.55 kB 591.81 kB +0.79% 103.21 kB 104.03 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js +0.86% 457.43 kB 461.38 kB +0.87% 76.26 kB 76.92 kB
react-native/shims/ReactNativeTypes.js +0.85% 7.05 kB 7.11 kB +1.32% 1.97 kB 1.99 kB
react-native/implementations/ReactFabric-profiling.fb.js +0.85% 451.09 kB 454.91 kB +0.90% 75.34 kB 76.02 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-profiling.js +0.81% 652.95 kB 658.24 kB +0.74% 111.79 kB 112.62 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-profiling.js +0.80% 658.88 kB 664.17 kB +0.73% 112.94 kB 113.76 kB
facebook-www/ReactReconciler-prod.modern.js +0.78% 496.37 kB 500.26 kB +0.83% 78.87 kB 79.52 kB
facebook-www/ReactReconciler-prod.classic.js +0.77% 506.53 kB 510.42 kB +0.83% 80.46 kB 81.12 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +0.71% 605.77 kB 610.05 kB +0.73% 97.16 kB 97.87 kB
facebook-www/ReactTestRenderer-dev.modern.js +0.66% 592.22 kB 596.11 kB +0.72% 95.69 kB 96.38 kB
facebook-www/ReactTestRenderer-dev.classic.js +0.66% 592.22 kB 596.11 kB +0.72% 95.69 kB 96.38 kB
facebook-www/ReactDOM-prod.modern.js +0.62% 668.19 kB 672.34 kB +0.63% 117.26 kB 118.00 kB
facebook-www/ReactDOM-prod.classic.js +0.61% 677.76 kB 681.91 kB +0.63% 118.94 kB 119.69 kB
facebook-www/ReactDOMTesting-prod.modern.js +0.61% 682.59 kB 686.74 kB +0.62% 120.90 kB 121.65 kB
facebook-www/ReactDOMTesting-prod.classic.js +0.60% 692.16 kB 696.31 kB +0.60% 122.53 kB 123.27 kB
react-native/implementations/ReactFabric-dev.fb.js +0.57% 751.95 kB 756.24 kB +0.62% 119.42 kB 120.17 kB
facebook-www/ReactDOM-profiling.modern.js +0.56% 742.84 kB 746.98 kB +0.58% 127.42 kB 128.16 kB
facebook-www/ReactDOM-profiling.classic.js +0.55% 750.94 kB 755.09 kB +0.59% 128.79 kB 129.55 kB
facebook-www/ReactART-dev.modern.js +0.55% 739.55 kB 743.62 kB +0.64% 115.27 kB 116.01 kB
facebook-www/ReactART-dev.classic.js +0.54% 749.08 kB 753.14 kB +0.61% 117.07 kB 117.79 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js +0.53% 760.83 kB 764.83 kB +0.61% 120.66 kB 121.39 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js +0.50% 1,122.13 kB 1,127.79 kB +0.49% 185.24 kB 186.16 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js +0.50% 1,138.40 kB 1,144.06 kB +0.49% 188.03 kB 188.94 kB
facebook-www/ReactReconciler-dev.modern.js +0.48% 855.85 kB 860.00 kB +0.55% 132.40 kB 133.13 kB
facebook-www/ReactReconciler-dev.classic.js +0.48% 865.08 kB 869.23 kB +0.53% 134.16 kB 134.87 kB
facebook-www/ReactDOM-dev.modern.js +0.37% 1,242.08 kB 1,246.69 kB +0.39% 204.80 kB 205.59 kB
facebook-www/ReactDOM-dev.classic.js +0.37% 1,251.25 kB 1,255.86 kB +0.38% 206.54 kB 207.31 kB
facebook-www/ReactDOMTesting-dev.modern.js +0.37% 1,258.61 kB 1,263.22 kB +0.39% 208.48 kB 209.29 kB
facebook-www/ReactDOMTesting-dev.classic.js +0.36% 1,267.78 kB 1,272.39 kB +0.39% 210.20 kB 211.02 kB

Generated by 🚫 dangerJS against cf5cb8c

@rickhanlonii rickhanlonii force-pushed the rh/default-transition-ff branch from b70ea23 to cf5cb8c Compare September 3, 2025 15:22
@rickhanlonii rickhanlonii merged commit 3168e08 into facebook:main Sep 3, 2025
241 checks passed
@rickhanlonii rickhanlonii deleted the rh/default-transition-ff branch September 3, 2025 16:33
github-actions bot pushed a commit that referenced this pull request Sep 3, 2025
@rickhanlonii
[flags] enable opt-in for enableDefaultTransitionIndicator (#34373)
3bfa7bb 
So we can test the feature.

DiffTrain build for [3168e08](3168e08)
github-actions bot pushed a commit that referenced this pull request Sep 3, 2025
@rickhanlonii
[flags] enable opt-in for enableDefaultTransitionIndicator (#34373)
0c939fc 
So we can test the feature.

DiffTrain build for [3168e08](3168e08)
@nextjs-bot nextjs-bot mentioned this pull request Sep 3, 2025
Merged
acdlite pushed a commit to vercel/next.js that referenced this pull request Sep 4, 2025
@nextjs-bot
Upgrade React from 2805f0ed-20250903 to 3302d1f7-20250903 (#83400)
b7de3b5 
[diff
facebook/react@2805f0ed...3302d1f7](facebook/react@2805f0e...3302d1f)

<details>
<summary>React upstream changes</summary>

- facebook/react#34376
- facebook/react#34375
- facebook/react#34373

</details>
EugeneChoi4 pushed a commit to EugeneChoi4/react that referenced this pull request Sep 4, 2025
@rickhanlonii @EugeneChoi4
[flags] enable opt-in for enableDefaultTransitionIndicator (facebook#…
20d4d43 
…34373)

So we can test the feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackpope jackpope jackpope approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rickhanlonii @react-sizebot @jackpope