[Tracks]: display method name and component name for updates in DEV #34463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: a9ad64c...21b4372 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
approved these changes
Sep 12, 2025
sebmarkbage
reviewed
Sep 12, 2025
| export function startUpdateTimerByLane( | ||
| lane: Lane, | ||
| method: string, | ||
| componentName: string | null, |
There was a problem hiding this comment.
You could just accept a Fiber and call getComponentName in here instead. That way you have the option of doing it lazily too and don't have to repeat it.
We deal with Fibers here anyway. E.g. this is what startHostActionTimer already does.
hoxyq
force-pushed
the
tracks/display-additional-fields-for-updates-in-dev
branch
from
2d49182 to
e6a43f5
Compare
hoxyq
force-pushed
the
tracks/display-additional-fields-for-updates-in-dev
branch
from
e6a43f5 to
21b4372
Compare
hoxyq
deleted the
tracks/display-additional-fields-for-updates-in-dev
branch
github-actions bot
pushed a commit
that referenced
this pull request
Sep 12, 2025
…34463) For every "Update" entry we are going to add properties that will be displayed when the user clicks on that entry: name of the method that caused this first update and name of the component where this update happened. We could use the name of the component as a deeplink to React DevTools components panel in the future, once we support stable identificators on Fibers. <img width="1444" height="530" alt="Screenshot 2025-09-10 at 18 31 10" src="https://github.com/user-attachments/assets/7f9af037-2e7f-4e7b-9b7e-bf9f7d5a6e72" /> <img width="2088" height="530" alt="Screenshot 2025-09-10 at 18 24 21" src="https://github.com/user-attachments/assets/f557a173-bd9b-43f7-9333-74066f433ced" /> <img width="2088" height="530" alt="Screenshot 2025-09-10 at 18 26 04" src="https://github.com/user-attachments/assets/ff37d13f-bbe3-4f85-800e-81aa3aed7833" /> DiffTrain build for [0c813c5](0c813c5)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 12, 2025
…34463) For every "Update" entry we are going to add properties that will be displayed when the user clicks on that entry: name of the method that caused this first update and name of the component where this update happened. We could use the name of the component as a deeplink to React DevTools components panel in the future, once we support stable identificators on Fibers. <img width="1444" height="530" alt="Screenshot 2025-09-10 at 18 31 10" src="https://github.com/user-attachments/assets/7f9af037-2e7f-4e7b-9b7e-bf9f7d5a6e72" /> <img width="2088" height="530" alt="Screenshot 2025-09-10 at 18 24 21" src="https://github.com/user-attachments/assets/f557a173-bd9b-43f7-9333-74066f433ced" /> <img width="2088" height="530" alt="Screenshot 2025-09-10 at 18 26 04" src="https://github.com/user-attachments/assets/ff37d13f-bbe3-4f85-800e-81aa3aed7833" /> DiffTrain build for [0c813c5](0c813c5)
|
Oh hell yes |
|
Something in here has broken how updates are logged. They don't show up for me at all. Or worse, I've been able to get them to overlap into two rows sometimes now. However that's so hard to repro I'm not sure if that was an existing issue. |
sebmarkbage
reviewed
Sep 17, 2025
| blockingUpdateMethodName = method; | ||
| if (__DEV__ && fiber != null) { | ||
| blockingUpdateComponentName = getComponentNameFromFiber(fiber); | ||
| } |
There was a problem hiding this comment.
We should always set the component name even if it's null because otherwise we can show the wrong component name for the next call that is null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For every "Update" entry we are going to add properties that will be displayed when the user clicks on that entry: name of the method that caused this first update and name of the component where this update happened.
We could use the name of the component as a deeplink to React DevTools components panel in the future, once we support stable identificators on Fibers.