[compiler] Export PluginOptions as a type that can be used in input positions
#34550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
force-pushed
the
sebbie/09-21-_compiler_export_pluginoptions_as_a_type_that_can_be_used_in_input_positions
branch
from
1f999f9 to
79aca40
Compare
poteto
approved these changes
Sep 22, 2025
eps1lon
deleted the
sebbie/09-21-_compiler_export_pluginoptions_as_a_type_that_can_be_used_in_input_positions
branch
This was referenced Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PluginOptionspreviously typed all its properties as (deeply required). This is unergonomic for users who'd have to wrap it inPartial<PluginOptions>. However, this is not even sufficient to properly typeenvironment. The correct type would've beenPartial<Omit<PluginOptions, 'environment'>> & {environment: Partial<EnvironmentConfig>}.This is no longer a trivial type construction so it warrants a dedicated type. Now the compiler distinguishes between
PluginOptions(the options you pass into the Compiler) andParsedPluginOptionswhich the Compiler uses internally and has all its properties defaultized.