Fix simdlib #2448
Closed
Fix simdlib #2448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdouze has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
BZO95
added a commit
to BZO95/faiss
that referenced
this pull request
Apr 10, 2025
Summary: - fix type of an argument of the `simd8uint32` constructor on `simdlib_emulated` - fix `blendv` on aarch64, which returns completely inverted results - remove unused `#include <faiss/utils/simdlib.h>` Pull Request resolved: facebookresearch/faiss#2448 Reviewed By: alexanderguzhva Differential Revision: D39259465 Pulled By: mdouze fbshipit-source-id: 646ee490269f9d71ff48a22e33c1250e115c02c2
samanthawaters8882michaeldonovan
added a commit
to samanthawaters8882michaeldonovan/faiss
that referenced
this pull request
Oct 12, 2025
Summary: - fix type of an argument of the `simd8uint32` constructor on `simdlib_emulated` - fix `blendv` on aarch64, which returns completely inverted results - remove unused `#include <faiss/utils/simdlib.h>` Pull Request resolved: facebookresearch/faiss#2448 Reviewed By: alexanderguzhva Differential Revision: D39259465 Pulled By: mdouze fbshipit-source-id: 646ee490269f9d71ff48a22e33c1250e115c02c2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simd8uint32constructor onsimdlib_emulatedblendvon aarch64, which returns completely inverted results#include <faiss/utils/simdlib.h>