Support character range formatting #3863
Merged
+61
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Feb 24, 2024
include/fmt/ranges.h
Outdated
| template <typename R, typename FormatContext> | ||
| template <typename R, typename FormatContext, typename U = T, | ||
| enable_if_t<std::is_same<U, Char>::value, bool> = true> | ||
| auto format(R&& range, FormatContext& ctx) const -> decltype(ctx.out()) { |
There was a problem hiding this comment.
To avoid duplication let's merge the two format overloads and either use if constexpr or move only the string-specific logic into a separate function.
There was a problem hiding this comment.
I tried if constexpr but its introduced in C++17, so tests would break. I pushed the changes to make the string logic a separate function, though I'm unsure if there's a way to cleanly handle the non-Char case, so any advice here would be appreciated.
vitaut
requested changes
Mar 3, 2024
|
@vitaut Thanks for the comments, pushed the latest changes |
vitaut
reviewed
Mar 6, 2024
vitaut
approved these changes
Mar 6, 2024
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to fix #3857. Implemented the
:sand:?sspecifier for ranges of characters. Specifically for the debug case (:?s), the underlying writer for escaped chars included single quotes in the output, so I converted the range into a string first. Added tests as well.