KEMBAR78
Fix CodeQL alert by marlenecota · Pull Request #3945 · fmtlib/fmt · GitHub
Skip to content

Conversation

@marlenecota
Copy link
Contributor

CodeQL found an issue in base.h via static analysis where the lower bound of the index id is not being checked before accessing array values_.

microsoft/react-native-windows#12702

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@vitaut vitaut merged commit 48c9084 into fmtlib:master Apr 30, 2024
@vitaut
Copy link
Contributor

vitaut commented Apr 30, 2024

Merged, thanks!

@marlenecota marlenecota deleted the codeql branch April 30, 2024 19:49
@marlenecota
Copy link
Contributor Author

Thanks, @vitaut! Would you happen to know when 10.2.2 might get published?

Arghnews pushed a commit to Arghnews/fmt that referenced this pull request May 1, 2024
@vitaut
Copy link
Contributor

vitaut commented May 4, 2024

There are no plans to publish a patch release at the moment. Note that negative IDs cannot appear when using the usual formatting API such as fmt::format or fmt::print. Therefore I don't think this fix warrants a special release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants