KEMBAR78
Enable race detection + test coverage in go test by timvaillancourt · Pull Request #131 · github/freno · GitHub
Skip to content

Conversation

@timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Aug 12, 2020

This PR enables the go test flags -covermode=atomic (to show test coverage %) and -race (to detect race conditions)

script/test is also updated to test ./pkg/... only, which contains all the code minus the cmd/freno/main.go file that has no tests

@timvaillancourt timvaillancourt changed the title Enable race detection in go test Enable race detection + test coverage in go test Aug 12, 2020
@timvaillancourt timvaillancourt added this to the v1.1.1 milestone Aug 24, 2020
@timvaillancourt timvaillancourt removed this from the v1.1.1 milestone Aug 29, 2020
@timvaillancourt timvaillancourt added this to the v1.1.1 milestone Nov 25, 2020
@timvaillancourt
Copy link
Contributor Author

Merging as this is a build-time-only PR

@timvaillancourt timvaillancourt merged commit 5f347a4 into master Nov 27, 2020
@timvaillancourt timvaillancourt deleted the go-test-race branch November 27, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant