KEMBAR78
Fix issue with opting out of headers when using header_hash method by oreoshake · Pull Request #193 · github/secure_headers · GitHub
Skip to content

Fix issue with opting out of headers when using header_hash method #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2015
Merged

Fix issue with opting out of headers when using header_hash method #193

merged 1 commit into from
Dec 3, 2015

Conversation

@oreoshake
Copy link
Contributor

The header_hash opt-out code was not consistent with the non-header-hash code. Mainly opting out of a header meant you would get an exception:

     NoMethodError:
       undefined method `name' for nil:NilClass
     # ./lib/secure_headers.rb:63:in `block in header_hash'
     # ./lib/secure_headers.rb:54:in `each'
     # ./lib/secure_headers.rb:54:in `inject'
     # ./lib/secure_headers.rb:54:in `header_hash'

I'm going to see if this issue exists on the 3.x branch as well.

/cc @moratorius

oreoshake added a commit that referenced this pull request Dec 3, 2015
@oreoshake
Merge pull request #193 from twitter/calling-name-on-nil-value
6c02a63 
Fix issue with opting out of headers when using header_hash method
@oreoshake oreoshake merged commit 6c02a63 into master Dec 3, 2015
@oreoshake oreoshake deleted the calling-name-on-nil-value branch December 3, 2015 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@oreoshake