target_experiment.py uploads reproducer and binary in target_experiment.py
#11700
Conversation
|
Will save fuzz target binary, crash reproducer, and other files to experiment bucket in OFG. |
|
/gcbrun skip |
There was a problem hiding this comment.
This might not be the case for all builds, since some targets may exist in subdirs. Let's skip uploading the binary for now
There was a problem hiding this comment.
Given we know the binary name, can I use find as a heuristic to find this path?
There was a problem hiding this comment.
Yes, that might work, if it's not too difficult to do this within a Cloud Build step.
There was a problem hiding this comment.
Added the script for this.
The script uses this path as the default, and if the target binary is not here, it uses find to locate it.
There was a problem hiding this comment.
Does this need to be a flag at all? When would we need to customize this behaviour?
There was a problem hiding this comment.
Ah, I was worrying that hardcoding this would affect other usages of this script.
If we don't have to customize it, then I can easily hardcode it.
There was a problem hiding this comment.
Should this be optional? This way, migrating oss-fuzz-gen will be seamless. Otherwise, as soon as this is submitted, oss-fuzz-gen will break in the interim before we add this flag there.
There was a problem hiding this comment.
Yes, good point.
I will make it optional.
There was a problem hiding this comment.
See below: let's make this conditional on the flag being passed.
DonggeLiu
force-pushed
the
target_exp_save_repro
branch
from
1c74928 to
2631a97
Compare
|
/gcbrun skip |
|
The artifact was not uploaded because the local dir missed a |
|
/gcbrun skip |
|
/gcbrun skip |
…nt.py` (#11713) Related: google/oss-fuzz-gen#172, #11700. This simplifies the link generation in benchmark `JSON`. Previously, the binary directory name matches the binary name, now it is always called `target_binary/`.
Fixes #156. Related: google/oss-fuzz#11700. Save GS bucket links to the reproducer and other statuses into a JSON file.
2 participants
Helps google/oss-fuzz-gen#156:
target_experiment.pytakes a new parameter,upload_reproducer_path.target_experiment.pysaves crash reproducer tolocal_artifect_path.target_experiment.pyuploads the fuzz target binary, the crash reproducer, and stacktrace to bucket directoryupload_reproducer_path.