envoy: prevent building with none sanitizer #9719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
|
Hi! The "none" sanitizer is required for fuzzing engines such as https://github.com/google/centipede. Is there a way to make that work? |
Our fuzzing build is currently broken when running in this mode: It will take some time to track why the linking is incorrect when there is no fuzzing library. I think we can merge this PR, and open another issue tracking why the build failed. |
DavidKorczynski
pushed a commit
that referenced
this pull request
Feb 17, 2023
In PR #9719 I accidentally added the memory sanitizer, which brakes the oss-fuzz build: ``` Step #23 - "compile-libfuzzer-memory-x86_64": ld.lld: error: undefined symbol: __msan_param_tls Step #23 - "compile-libfuzzer-memory-x86_64": >>> referenced by gtest-internal.h:522 (external/com_google_googletest/googletest/include/gtest/internal/gtest-internal.h:522) Step #23 - "compile-libfuzzer-memory-x86_64": >>> bazel-out/k8-fastbuild-ST-d2373e19ffe2/bin/test/common/router/_objs/config_impl_test_lib/config_impl_test.pic.o:(testing::internal::SuiteApiResolver<Envoy::Router::(anonymous namespace)::RouteMatcherTest>::GetSetUpCaseOrSuite(char const*, int)) Step #23 - "compile-libfuzzer-memory-x86_64": >>> referenced by gtest-internal.h:543 (external/com_google_googletest/googletest/include/gtest/internal/gtest-internal.h:543) Step #23 - "compile-libfuzzer-memory-x86_64": >>> bazel-out/k8-fastbuild-ST-d2373e19ffe2/bin/test/common/router/_objs/config_impl_test_lib/config_impl_test.pic.o:(testing::internal::SuiteApiResolver<Envoy::Router::(anonymous namespace)::RouteMatcherTest>::GetTearDownCaseOrSuite(char const*, int)) Step #23 - "compile-libfuzzer-memory-x86_64": >>> referenced by gtest-internal.h:522 (external/com_google_googletest/googletest/include/gtest/internal/gtest-internal.h:522) Step #23 - "compile-libfuzzer-memory-x86_64": >>> bazel-out/k8-fastbuild-ST-d2373e19ffe2/bin/test/common/router/_objs/config_impl_test_lib/config_impl_test.pic.o:(testing::internal::SuiteApiResolver<Envoy::Router::(anonymous namespace)::HeaderTransformsDoFormattingTest>::GetSetUpCaseOrSuite(char const*, int)) Step #23 - "compile-libfuzzer-memory-x86_64": >>> referenced 377754 more times ``` This PR keeps the address and undefined sanitizer. Signed-off-by: Adi Suissa-Peleg <adip@google.com>
eamonnmcmanus
pushed a commit
to eamonnmcmanus/oss-fuzz
that referenced
this pull request
Mar 15, 2023
PR google#9653 added a "none" sanitizer that broke Envoy's build. This PR explicitly lists the allowed sanitizers (address, memory, and undefined). Signed-off-by: Adi Suissa-Peleg <adip@google.com>
eamonnmcmanus
pushed a commit
to eamonnmcmanus/oss-fuzz
that referenced
this pull request
Mar 15, 2023
In PR google#9719 I accidentally added the memory sanitizer, which brakes the oss-fuzz build: ``` Step google#23 - "compile-libfuzzer-memory-x86_64": ld.lld: error: undefined symbol: __msan_param_tls Step google#23 - "compile-libfuzzer-memory-x86_64": >>> referenced by gtest-internal.h:522 (external/com_google_googletest/googletest/include/gtest/internal/gtest-internal.h:522) Step google#23 - "compile-libfuzzer-memory-x86_64": >>> bazel-out/k8-fastbuild-ST-d2373e19ffe2/bin/test/common/router/_objs/config_impl_test_lib/config_impl_test.pic.o:(testing::internal::SuiteApiResolver<Envoy::Router::(anonymous namespace)::RouteMatcherTest>::GetSetUpCaseOrSuite(char const*, int)) Step google#23 - "compile-libfuzzer-memory-x86_64": >>> referenced by gtest-internal.h:543 (external/com_google_googletest/googletest/include/gtest/internal/gtest-internal.h:543) Step google#23 - "compile-libfuzzer-memory-x86_64": >>> bazel-out/k8-fastbuild-ST-d2373e19ffe2/bin/test/common/router/_objs/config_impl_test_lib/config_impl_test.pic.o:(testing::internal::SuiteApiResolver<Envoy::Router::(anonymous namespace)::RouteMatcherTest>::GetTearDownCaseOrSuite(char const*, int)) Step google#23 - "compile-libfuzzer-memory-x86_64": >>> referenced by gtest-internal.h:522 (external/com_google_googletest/googletest/include/gtest/internal/gtest-internal.h:522) Step google#23 - "compile-libfuzzer-memory-x86_64": >>> bazel-out/k8-fastbuild-ST-d2373e19ffe2/bin/test/common/router/_objs/config_impl_test_lib/config_impl_test.pic.o:(testing::internal::SuiteApiResolver<Envoy::Router::(anonymous namespace)::HeaderTransformsDoFormattingTest>::GetSetUpCaseOrSuite(char const*, int)) Step google#23 - "compile-libfuzzer-memory-x86_64": >>> referenced 377754 more times ``` This PR keeps the address and undefined sanitizer. Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #9653 added a "none" sanitizer that broke Envoy's build.
This PR explicitly lists the allowed sanitizers (address, memory, and undefined).