KEMBAR78
update autovalue by elharo · Pull Request #103 · googleapis/api-common-java · GitHub
Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Dec 5, 2019

@chingor13

fixes #66
fixes #100

@elharo elharo requested a review from chingor13 December 5, 2019 13:02
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2019
@elharo
Copy link
Contributor Author

elharo commented Dec 5, 2019

Fails on JDK 7:

BUILD FAILED in 7s
1 actionable task: 1 executed

�[31;1mThe command "eval ./gradlew assemble " failed. Retrying, 3 of 3.�[0m

Task :compileJava FAILED

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':compileJava'.

com/google/auto/value/extension/memoized/processor/MemoizedValidator : Unsupported major.minor version 52.0

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #103 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #103   +/-   ##
=========================================
  Coverage     60.48%   60.48%           
  Complexity      147      147           
=========================================
  Files            14       14           
  Lines           615      615           
  Branches         93       92    -1     
=========================================
  Hits            372      372           
  Misses          217      217           
  Partials         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0761dde...01f437c. Read the comment docs.

Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping ping ping

compileOnly libraries.autovalue,
libraries.error_prone_annotations
compileOnly libraries.error_prone_annotations,
libraries.auto_value_annotations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think auto_value is the compile only dependency and auto_value_annotations is an actual dependency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done for annotation. auto_value should be on the annotationProcessor path.

build.gradle Outdated
codeGeneration libraries.auto_value, libraries.jsr305
compile libraries.jsr305
compileOnly libraries.autovalue
compileOnly libraries.auto_value_annotations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@elharo elharo merged commit cb7171e into master Dec 11, 2019
@elharo elharo deleted the auto branch December 11, 2019 23:36
miraleung pushed a commit that referenced this pull request Jun 4, 2020
* update autovalue
* auto value requires Java 8 compiler
* give auto_value_annotations compile scope
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade autovalue to 1.7 Gradle 5.0 deprecation warning: annotation processor path

3 participants