KEMBAR78
build on trusty by elharo · Pull Request #81 · googleapis/api-common-java · GitHub
Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Apr 25, 2019

@andreamlin fix #59

Trusty does not support Oracle Java 7 but does support OpenJDK 7.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 25, 2019
@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #81   +/-   ##
=========================================
  Coverage     60.32%   60.32%           
  Complexity      146      146           
=========================================
  Files            14       14           
  Lines           615      615           
  Branches         93       93           
=========================================
  Hits            371      371           
  Misses          218      218           
  Partials         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c545f...7255091. Read the comment docs.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 2, 2019
@sduskis sduskis requested a review from andreamlin May 28, 2019 14:22
@sduskis sduskis requested a review from vchudnov-g June 24, 2019 15:02
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Jul 3, 2019
@vchudnov-g
Copy link

Were you able to test this locally, particularly in light of your comment above? (Not a Java expert, sorry if this question is naïve)

@elharo
Copy link
Contributor Author

elharo commented Aug 28, 2019

This change doesn't matter locally. It only controls what we use in the CI environment.

@elharo elharo merged commit fc3011e into googleapis:master Aug 29, 2019
@elharo elharo deleted the hub branch August 29, 2019 18:56
miraleung pushed a commit that referenced this pull request Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Precise builds:

4 participants