Storage retry #51
Merged
Storage retry #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
tritone
reviewed
Aug 6, 2021
storage/v1/proto/google/cloud/conformance/storage/v1/tests.proto
Outdated
Show resolved
Hide resolved
storage/v1/validator.go
Outdated
| } | ||
|
|
||
| log.Printf("Validating: %v/%v", dir, f.Name()) | ||
| if strings.Contains(f.Name(), "v4_signatures.json") { |
There was a problem hiding this comment.
Maybe we can just make a map between the expected jsons and protos and use that, rather than iterating through the directory?
Also, does this get run in the CI for this repo?
There was a problem hiding this comment.
I cleaned things up a little bit, so they're at least sharing some logic. Not sure if you were hoping for something else.
Yeah, CI does run. The Kokoro CI status runs the validation programs.
cojenco
reviewed
Aug 19, 2021
BenWhitehead
added a commit
to googleapis/java-conformance-tests
that referenced
this pull request
Aug 25, 2021
…260 (#350) googleapis/conformance-tests@37ddc58 feat: add storage retry tests ([#51](googleapis/conformance-tests#51)) googleapis/conformance-tests@acf856b chore: update CODEOWNERS to team that uses these tests ([#52](googleapis/conformance-tests#52)) googleapis/conformance-tests@52d638f chore: add CODEOWNERS ([#50](googleapis/conformance-tests#50)) googleapis/conformance-tests@5c6e4fc chore: Configure Renovate ([#48](googleapis/conformance-tests#48)) googleapis/conformance-tests@9ae763e added start_after for document snapshot ([#45](googleapis/conformance-tests#45)) googleapis/conformance-tests@25ca4c5 chore: add a Code of Conduct ([#43](googleapis/conformance-tests#43)) googleapis/conformance-tests@e8f4938 chore: add SECURITY.md ([#44](googleapis/conformance-tests#44)) googleapis/conformance-tests@a9ab154 chore: add go.mod, get tests passing ([#47](googleapis/conformance-tests#47)) googleapis/conformance-tests@e128d77 Add Firestore ArrayUnion merge test ([#42](googleapis/conformance-tests#42)) Full diff: googleapis/conformance-tests@a3a00aa...37ddc58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.