KEMBAR78
feat(option/internaloption): add new allowHardBoundTokens option by yamandabbagh · Pull Request #2975 · googleapis/google-api-go-client · GitHub
Skip to content

Conversation

@yamandabbagh
Copy link
Contributor

Add allowHardBoundTokens option to the internaloption. This option will be used internally only to allow auto-generated clients to request a hard-bound tokens. Hard-bound tokens are tokens that include binding that must be enforced regardless of the IAM policy.

@yamandabbagh yamandabbagh requested a review from a team as a code owner January 22, 2025 17:04
@codyoss codyoss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 22, 2025
@quartzmo quartzmo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 27, 2025
@quartzmo
Copy link
Member

Do not merge was applied pending review of the design doc, which @codyoss approved.

Add more details about the AllowHardBoundTokens internal option.
Add a link for information about ALTS
@quartzmo quartzmo added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Feb 10, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2025
@yamandabbagh
Copy link
Contributor Author

kokoro rerun

@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2025
@codyoss
Copy link
Member

codyoss commented Feb 10, 2025

The failure is do to the file needing to be formatted:

+ gofmt -s -d -l .
+ tee /dev/stderr
+ read
option/internaloption/internaloption.go

@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1cc19b7 into googleapis:main Feb 10, 2025
5 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 10, 2025
quartzmo pushed a commit to googleapis/google-cloud-go that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants