KEMBAR78
fix: refactor compute and cloudshell credentials to pass quota project to base class by sai-sunder-s · Pull Request #1284 · googleapis/google-auth-library-java · GitHub
Skip to content

fix: refactor compute and cloudshell credentials to pass quota project to base class #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 17, 2024
Merged

fix: refactor compute and cloudshell credentials to pass quota project to base class #1284

merged 6 commits into from
Jan 17, 2024

Conversation

@sai-sunder-s
Copy link
Contributor

@sai-sunder-s sai-sunder-s commented Sep 13, 2023 •
edited by TimurSadykov
Loading

Currently quota project that is set in the builder is dropped when build() is called for cloudshell and gce creds because the constructors are not rolling up the builders upto the base class.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

TimurSadykov
TimurSadykov suggested changes Oct 2, 2023
View reviewed changes
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, except margin visibility

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Jan 10, 2024
@sai-sunder-s sai-sunder-s changed the title fix:refactor compute and cloudshell credentials to pass quota project to base class fix: refactor compute and cloudshell credentials to pass quota project to base class Jan 10, 2024
@sai-sunder-s sai-sunder-s marked this pull request as ready for review January 10, 2024 18:43
@sai-sunder-s sai-sunder-s requested a review from a team as a code owner January 10, 2024 18:43
TimurSadykov
TimurSadykov suggested changes Jan 11, 2024
View reviewed changes
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add more tests

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 17, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

TimurSadykov
TimurSadykov approved these changes Jan 17, 2024
View reviewed changes
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TimurSadykov TimurSadykov merged commit fb75239 into googleapis:main Jan 17, 2024
@release-please release-please bot mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TimurSadykov TimurSadykov TimurSadykov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sai-sunder-s @TimurSadykov