chore: update codeowners #1126
Merged
chore: update codeowners #1126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burkedavison
approved these changes
Oct 28, 2024
|
|
||
|
|
||
| # The java-samples-reviewers team is the default owner for samples changes | ||
| samples/**/*.java @googleapis/java-samples-reviewers |
There was a problem hiding this comment.
Thanks for pointing this out. I cross checked with CODEOWNERS in google-auth-library-java here, and suspect the error is this team does not have access to this repo.
However, I don't have settings tab. @westarle @TimurSadykov can you please help verify?
blakeli0
reviewed
Oct 28, 2024
.github/CODEOWNERS
Outdated
| # The java-samples-reviewers team is the default owner for samples changes | ||
| samples/**/*.java @googleapis/java-samples-reviewers | ||
|
|
||
| # Generated snippets should not be owned by samples reviewers |
There was a problem hiding this comment.
I don't think there are any generated samples in this repo, and I don't think there will be either. It is mostly a concept for GAPIC client libraries. I think we can delete this section.
westarle
approved these changes
Oct 30, 2024
product-auto-label
bot
added
size: s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.