refactor(bigquery): Clean up sample test resources, fix comments #3823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
|
Looks like the samples test is still failing since the updated job_creation_optional change hasn't been release yet. |
PhongChuong
approved these changes
Jun 4, 2025
lqiu96
pushed a commit
that referenced
this pull request
Jun 5, 2025
* refactor(bigquery): Clean up sample test resources, fix comments * fix style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just to remove some out of date comments and fix some inefficient code, namely looping through a map instead of searching by key. This PR also cleans up the tests resources found to be leaking in b/421174158