KEMBAR78
fix: It seems GAPIC is not generated expected headers for bidi streaming client lib, apply a temp fix to unblock customers by yirutang · Pull Request #1017 · googleapis/java-bigquerystorage · GitHub
Skip to content

Conversation

@yirutang
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested review from a team and stephaniewang526 April 20, 2021 00:46
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Apr 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2021
@yirutang yirutang marked this pull request as draft April 20, 2021 19:48
@yirutang yirutang changed the title repro fix: It seems GAPIC is not generated expected headers for bidi streaming client lib, apply a temp fix to unblock customers Apr 20, 2021
@yirutang yirutang marked this pull request as ready for review April 20, 2021 20:11
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #1017 (62f3d5c) into master (969ec2e) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1017      +/-   ##
============================================
- Coverage     80.00%   79.83%   -0.17%     
  Complexity      709      709              
============================================
  Files            61       61              
  Lines          3961     3963       +2     
  Branches        264      263       -1     
============================================
- Hits           3169     3164       -5     
  Misses          669      669              
- Partials        123      130       +7     
Impacted Files Coverage Δ Complexity Δ
...cloud/bigquery/storage/v1beta2/StreamWriterV2.java 95.70% <100.00%> (-0.40%) 39.00 <0.00> (ø)
.../bigquery/storage/v1beta2/BigQueryWriteClient.java 70.76% <0.00%> (-4.62%) 33.00% <0.00%> (ø%)
...ud/bigquery/storage/v1/BaseBigQueryReadClient.java 58.53% <0.00%> (-2.44%) 12.00% <0.00%> (ø%)
...gquery/storage/v1beta2/BaseBigQueryReadClient.java 58.53% <0.00%> (-2.44%) 12.00% <0.00%> (ø%)
...ery/storage/v1beta1/BaseBigQueryStorageClient.java 71.18% <0.00%> (-1.70%) 22.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 969ec2e...62f3d5c. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 9c1ed55 into googleapis:master Apr 20, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 21, 2021
@yirutang yirutang deleted the region branch April 30, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants