KEMBAR78
feat: Expand bytes field type handling by JacobStocklass · Pull Request #1180 · googleapis/java-bigquerystorage · GitHub
Skip to content

Conversation

@JacobStocklass
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

Add the ability for a single BYTES field to handle a JSONArray of bytes, and add the ability for a repeated BYTES field to handle a ByteString.
Index to i
@JacobStocklass JacobStocklass requested review from a team, loferris and yirutang July 8, 2021 20:29
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Jul 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 8, 2021
@stephaniewang526 stephaniewang526 removed the request for review from loferris July 9, 2021 11:13
@stephaniewang526 stephaniewang526 merged commit aab33a5 into master Jul 14, 2021
@stephaniewang526 stephaniewang526 deleted the JacobStocklass-patch-1 branch July 14, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants