KEMBAR78
Fix decimal mapping when value is array by ramasLTU · Pull Request #1357 · googleapis/java-bigquerystorage · GitHub
Skip to content

Conversation

@ramasLTU
Copy link
Contributor

Added missing return, when processing big decimal field which has its value in byte array format.
Previously algorithm would do the mapping, set the values, but would not exit with return and fallback to IllegalArgumentException at the end of the method.

Fixes #1356☕️

@ramasLTU ramasLTU requested review from a team and tswast October 13, 2021 07:21
@google-cla
Copy link

google-cla bot commented Oct 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Oct 13, 2021
@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 13, 2021
@ramasLTU
Copy link
Contributor Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Oct 13, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@ramasLTU ramasLTU force-pushed the fix/decimal_to_proto branch from 8a1f51c to 1cf49e0 Compare October 13, 2021 07:37
@google-cla
Copy link

google-cla bot commented Oct 13, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@ramasLTU ramasLTU force-pushed the fix/decimal_to_proto branch from 1cf49e0 to cea47e0 Compare October 13, 2021 07:39
@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 13, 2021
@ramasLTU ramasLTU force-pushed the fix/decimal_to_proto branch from cea47e0 to a97ab66 Compare October 13, 2021 07:54
@tswast tswast requested review from stephaniewang526 and removed request for tswast October 13, 2021 20:13
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
Added missing return, when processing big decimal field which has it's value in byte array format.
Previously algorithm would set the value, but would not exit and fallback to IllegalArgumentException
at the end of the mapping method.
@stephaniewang526 stephaniewang526 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 18, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 18, 2021
@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2021
@ramasLTU ramasLTU requested a review from a team as a code owner October 18, 2021 18:48
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 21b9e25 into googleapis:main Oct 18, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 18, 2021
gcf-owl-bot bot added a commit that referenced this pull request Feb 25, 2022
Source-Link: googleapis/synthtool@e122cb0
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:387835a1375a0049ec44e02542c844302854c732d8291bdf8e472c0ff70a8f67
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 25, 2022
Source-Link: googleapis/synthtool@e122cb0
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:387835a1375a0049ec44e02542c844302854c732d8291bdf8e472c0ff70a8f67
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
…oogleapis#828)

Source-Link: googleapis/synthtool@e122cb0
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:387835a1375a0049ec44e02542c844302854c732d8291bdf8e472c0ff70a8f67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery storage: errors while trying to insert bytes array

5 participants