KEMBAR78
fix: Add documentation to Exceptions by yirutang · Pull Request #1745 · googleapis/java-bigquerystorage · GitHub
Skip to content

fix: Add documentation to Exceptions #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 12, 2022
Merged

fix: Add documentation to Exceptions #1745

merged 5 commits into from
Aug 12, 2022

Conversation

@yirutang
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@yirutang yirutang requested review from a team and loferris August 12, 2022 00:14
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Aug 12, 2022
@yirutang yirutang requested a review from shollyman August 12, 2022 00:14
shollyman
shollyman reviewed Aug 12, 2022
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some alternate language for each of these.

@yirutang yirutang requested a review from a team as a code owner August 12, 2022 17:47
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022
@yirutang yirutang added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 12, 2022
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 12, 2022
@yirutang yirutang merged commit 3bc7aca into googleapis:main Aug 12, 2022
@release-please release-please bot mentioned this pull request Aug 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

@loferris loferris Awaiting requested review from loferris

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yirutang @shollyman @yoshi-kokoro