fix: return row-level error information via an AppendSerializtionError #1813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
yirutang
approved these changes
Oct 3, 2022
| LOG.info("Sending three messages"); | ||
| ApiFuture<AppendRowsResponse> futureResponse = | ||
| streamWriter.append( | ||
| CreateProtoRows(new String[] {"aaabbbcccddd", "bbb", "cccdddeeefffggg"}), -1); |
There was a problem hiding this comment.
Shouldn't block this checkin, could you try to hit the timestamp error in the bug to verify that path is fixed?
yirutang
reviewed
Oct 3, 2022
yoshi-kokoro
removed
the
kokoro:run
agrawal-siddharth
force-pushed
the
return-error-rows
branch
from
f85dd62 to
0590379
Compare
agrawal-siddharth
changed the title
yirutang
added
kokoro:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:run
yirutang
changed the title
gcf-owl-bot bot
added a commit
that referenced
this pull request
Jun 16, 2023
* chore: Update `dependabot.yml` template not to touch pip dependencies Source-Link: googleapis/synthtool@f961eb0 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:af2eda87a54601ae7b7b2be5055c17b43ac98a7805b586772db314de8a7d4a1d
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this pull request
Oct 7, 2023
…#1199) * chore: Update `dependabot.yml` template not to touch pip dependencies Source-Link: googleapis/synthtool@f961eb0 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:af2eda87a54601ae7b7b2be5055c17b43ac98a7805b586772db314de8a7d4a1d Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: return list of row errors from append
fix: return row-level error information via an AppendSerializtionError exception
END_COMMIT_OVERRIDE