KEMBAR78
feat: wire and expose profiler api to the StreamWirter/JsonStreamWriter by GaoleMeng · Pull Request #2561 · googleapis/java-bigquerystorage · GitHub
Skip to content

Conversation

@GaoleMeng
Copy link
Contributor

User would be able to call setEnableLatencyProfiler(true) on top of the streamWriter/jsonStreamWriter to understand where is the time spent periodically for the top most latency requests.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@GaoleMeng GaoleMeng requested review from a team as code owners July 16, 2024 22:56
@GaoleMeng GaoleMeng requested a review from alvarowolfx July 16, 2024 22:56
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jul 16, 2024
@GaoleMeng GaoleMeng requested a review from yirutang July 16, 2024 22:56
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Jul 16, 2024
@GaoleMeng GaoleMeng force-pushed the use_profiler branch 3 times, most recently from b4a8c15 to f863bd1 Compare July 16, 2024 23:04
@GaoleMeng GaoleMeng changed the title Wire and expose profiler api to the StreamWirter/JsonStreamWriter feat: wire and expose profiler api to the StreamWirter/JsonStreamWriter Jul 16, 2024
@GaoleMeng GaoleMeng force-pushed the use_profiler branch 9 times, most recently from 6c87ab9 to 97677f6 Compare July 17, 2024 20:41
@GaoleMeng GaoleMeng force-pushed the use_profiler branch 4 times, most recently from 567c3af to ab6f8eb Compare July 17, 2024 21:40
@GaoleMeng GaoleMeng merged commit 16f19dd into googleapis:main Jul 17, 2024
yifatgortler pushed a commit to yifatgortler/java-bigquerystorage that referenced this pull request Jul 25, 2024
…er (googleapis#2561)

* Add profiler for request execution details. The usage of the new API
will be added in the next PR

* Add profiler for request execution details. The usage of the new API
will be added in the next PR

* add new code change

* feat: wire profiler to the actual codebase

* .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants