fix: Avoid setting error on response future twice #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
============================================
- Coverage 74.35% 74.33% -0.02%
- Complexity 376 377 +1
============================================
Files 45 45
Lines 2515 2525 +10
Branches 98 100 +2
============================================
+ Hits 1870 1877 +7
- Misses 594 596 +2
- Partials 51 52 +1
Continue to review full report at Codecov.
|
modified: google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
stephaniewang526
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
stephaniewang526
approved these changes
May 8, 2020
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this pull request
Oct 7, 2023
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/fc1413bf-7539-42ca-a3cb-6a8d29e26892/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@6abb590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a test flakiness that sometimes, we get unexpected StatusUnknown error set from stream closed. It could be a error race that the second error overrides the first error.