KEMBAR78
fix: add retry logic for readrows by pmakani · Pull Request #263 · googleapis/java-bigquerystorage · GitHub
Skip to content

fix: add retry logic for readrows #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 26, 2020
Merged

fix: add retry logic for readrows #263

merged 3 commits into from
May 26, 2020

Conversation

@pmakani
Copy link
Contributor

@pmakani pmakani commented May 8, 2020 •
edited by stephaniewang526
Loading

Fixes #86

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2020
@pmakani pmakani requested a review from stephaniewang526 May 8, 2020 15:15
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020 •
edited
Loading

Codecov Report

Merging #263 into master will increase coverage by 0.60%.
The diff coverage is 83.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #263      +/-   ##
============================================
+ Coverage     74.16%   74.76%   +0.60%     
- Complexity      382      410      +28     
============================================
  Files            45       48       +3     
  Lines          2570     2754     +184     
  Branches        101      126      +25     
============================================
+ Hits           1906     2059     +153     
- Misses          610      624      +14     
- Partials         54       71      +17
Impacted Files Coverage Δ Complexity Δ
...rage/v1/stub/readrows/ApiResultRetryAlgorithm.java 78.26% <78.26%> (ø) 9.00 <9.00> (?)
...rage/v1/stub/readrows/ReadRowsAttemptCallable.java 78.94% <78.94%> (ø) 16.00 <16.00> (?)
...age/v1/stub/readrows/ReadRowsRetryingCallable.java 95.23% <95.23%> (ø) 2.00 <2.00> (?)
...uery/storage/v1/stub/EnhancedBigQueryReadStub.java 88.05% <96.55%> (+5.13%) 8.00 <3.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1c24d...90c66bb. Read the comment docs.

@pmakani pmakani force-pushed the internal-retrying branch from 360ef1e to 90c66bb Compare May 22, 2020 06:23
@pmakani pmakani marked this pull request as ready for review May 22, 2020 10:34
@stephaniewang526 stephaniewang526 mentioned this pull request May 26, 2020
Closed
@stephaniewang526 stephaniewang526 merged commit 50345b6 into googleapis:master May 26, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request May 27, 2020
@release-please
chore: release 0.133.1 (#293)
2286603 
🤖 I have created a release \*beep\* \*boop\* 
---
### [0.133.1](https://www.github.com/googleapis/java-bigquerystorage/compare/v0.133.0...v0.133.1) (2020-05-27)


### Bug Fixes

* add retry logic for readrows ([#263](https://www.github.com/googleapis/java-bigquerystorage/issues/263)) ([50345b6](https://www.github.com/googleapis/java-bigquerystorage/commit/50345b653d59209b7912b56b76c6d41e289ecb30))


### Dependencies

* bump shared-deps version and add back certain test deps ([#300](https://www.github.com/googleapis/java-bigquerystorage/issues/300)) ([edfa26b](https://www.github.com/googleapis/java-bigquerystorage/commit/edfa26bb5bfa506004a6d3e39775f9f66b956db9))
* update dependency com.google.cloud:google-cloud-bigquery to v1.115.1 ([#294](https://www.github.com/googleapis/java-bigquerystorage/issues/294)) ([75a08c3](https://www.github.com/googleapis/java-bigquerystorage/commit/75a08c3683fde88264d310f965a0c973b54dfd9e))
* update dependency com.google.cloud:google-cloud-bigquery to v1.116.0 ([#296](https://www.github.com/googleapis/java-bigquerystorage/issues/296)) ([d243ece](https://www.github.com/googleapis/java-bigquerystorage/commit/d243ece29dd1494531f623b69e609fb833e970dc))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.4.0 ([#291](https://www.github.com/googleapis/java-bigquerystorage/issues/291)) ([20b2963](https://www.github.com/googleapis/java-bigquerystorage/commit/20b2963bbf315951d1607bee63a7aa083cdb6c86))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@pmakani pmakani deleted the internal-retrying branch May 29, 2020 04:42
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@renovate-bot
deps: update dependency com.google.guava:guava to v30 (googleapis#263)
4e81dab
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@release-please
chore: release 0.122.0 (googleapis#277)
e164938 
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.122.0](https://www.github.com/googleapis/java-storage-nio/compare/v0.121.2...v0.122.0) (2020-11-06)


### Features

* update cloudstorageconfiguration to improve copy accross cross-bucket performance ([googleapis#168](https://www.github.com/googleapis/java-storage-nio/issues/168)) ([db74524](https://www.github.com/googleapis/java-storage-nio/commit/db74524d68487df71c80b122d8c0ff384dc9ace3))
* **deps:** adopt flatten plugin and google-cloud-shared-dependencies ([googleapis#156](https://www.github.com/googleapis/java-storage-nio/issues/156)) ([510f6a5](https://www.github.com/googleapis/java-storage-nio/commit/510f6a5efc4a13b010020a8d67ec1511bbd46564))


### Bug Fixes

* FakeStorageRpc#list to filtering the files by bucket and prefix ([googleapis#208](https://www.github.com/googleapis/java-storage-nio/issues/208)) ([21f606e](https://www.github.com/googleapis/java-storage-nio/commit/21f606eca67b1c8a471ee28f7e2dd3851a0c493e))
* implement writeWithResponse in FakeStorageRpc ([googleapis#187](https://www.github.com/googleapis/java-storage-nio/issues/187)) ([10ddfae](https://www.github.com/googleapis/java-storage-nio/commit/10ddfae3923f1d5e64b151293db238f1af433d03))


### Dependencies

* update dependency com.google.apis:google-api-services-storage to v1-rev20200611-1.30.9 ([googleapis#166](https://www.github.com/googleapis/java-storage-nio/issues/166)) ([3cab5f2](https://www.github.com/googleapis/java-storage-nio/commit/3cab5f25e081c0198d06903a42c7de3dbd34bbad))
* update dependency com.google.apis:google-api-services-storage to v1-rev20200727-1.30.10 ([googleapis#171](https://www.github.com/googleapis/java-storage-nio/issues/171)) ([62998f0](https://www.github.com/googleapis/java-storage-nio/commit/62998f0adfb22b194e2dd633532e13bf27a79479))
* update dependency com.google.apis:google-api-services-storage to v1-rev20200814-1.30.10 ([googleapis#206](https://www.github.com/googleapis/java-storage-nio/issues/206)) ([0d7cd44](https://www.github.com/googleapis/java-storage-nio/commit/0d7cd44e73b0b9456a8ba96cc6e6d0e60a0b7d4e))
* update dependency com.google.apis:google-api-services-storage to v1-rev20200927-1.30.10 ([googleapis#233](https://www.github.com/googleapis/java-storage-nio/issues/233)) ([91b7918](https://www.github.com/googleapis/java-storage-nio/commit/91b7918539186763ecaa377cfb6f3908105df279))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.0 ([googleapis#226](https://www.github.com/googleapis/java-storage-nio/issues/226)) ([83acbd7](https://www.github.com/googleapis/java-storage-nio/commit/83acbd766b06d66fc9a41385fdd49aa57d9a0291))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.1 ([googleapis#239](https://www.github.com/googleapis/java-storage-nio/issues/239)) ([bd1928d](https://www.github.com/googleapis/java-storage-nio/commit/bd1928da234dae6fc2fb1ad6658d89a9ebc7af82))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.2 ([googleapis#243](https://www.github.com/googleapis/java-storage-nio/issues/243)) ([4ca9869](https://www.github.com/googleapis/java-storage-nio/commit/4ca9869d99fc3d2e578fb86fbd9053f855f1e51c))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.12.0 ([googleapis#246](https://www.github.com/googleapis/java-storage-nio/issues/246)) ([3e6171b](https://www.github.com/googleapis/java-storage-nio/commit/3e6171b2d4c4c7832b62288faf30f767c5278762))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.12.1 ([googleapis#255](https://www.github.com/googleapis/java-storage-nio/issues/255)) ([73d7dd2](https://www.github.com/googleapis/java-storage-nio/commit/73d7dd2ec6ca371480955c844ffb5e6aed4f608f))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.13.0 ([googleapis#260](https://www.github.com/googleapis/java-storage-nio/issues/260)) ([54895cf](https://www.github.com/googleapis/java-storage-nio/commit/54895cf441f1e1723cf941aa1f6cab249acae6b8))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.14.1 ([googleapis#271](https://www.github.com/googleapis/java-storage-nio/issues/271)) ([058d7c9](https://www.github.com/googleapis/java-storage-nio/commit/058d7c9c1471846f3d897cac31cb5f6d42ce5a7d))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.2 ([googleapis#167](https://www.github.com/googleapis/java-storage-nio/issues/167)) ([3b14bbc](https://www.github.com/googleapis/java-storage-nio/commit/3b14bbc05d5658c57d4f272fdfdf152d7d9ee18d))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([googleapis#169](https://www.github.com/googleapis/java-storage-nio/issues/169)) ([4e7bac1](https://www.github.com/googleapis/java-storage-nio/commit/4e7bac10c2466d1407e8f1a6de838261e6c1b097))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.4 ([googleapis#189](https://www.github.com/googleapis/java-storage-nio/issues/189)) ([af492b8](https://www.github.com/googleapis/java-storage-nio/commit/af492b8068101727793e64e89da2778205fa08b6))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.6 ([googleapis#191](https://www.github.com/googleapis/java-storage-nio/issues/191)) ([9bbc1fc](https://www.github.com/googleapis/java-storage-nio/commit/9bbc1fc755271f2ac6b798d50f6c0ba8e022c589))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.0 ([googleapis#202](https://www.github.com/googleapis/java-storage-nio/issues/202)) ([cf312a3](https://www.github.com/googleapis/java-storage-nio/commit/cf312a3fe46ec446d1b5ee418849b3ab9abee87e))
* update dependency com.google.cloud:google-cloud-storage to v1.110.0 ([googleapis#154](https://www.github.com/googleapis/java-storage-nio/issues/154)) ([fd6de38](https://www.github.com/googleapis/java-storage-nio/commit/fd6de38ee63376afff03c7e794dce1f4524a4375))
* update dependency com.google.cloud:google-cloud-storage to v1.112.0 ([googleapis#199](https://www.github.com/googleapis/java-storage-nio/issues/199)) ([8a38817](https://www.github.com/googleapis/java-storage-nio/commit/8a3881732551bcef1d76f76026a29071fc50dd43))
* update dependency com.google.cloud:google-cloud-storage to v1.113.0 ([googleapis#205](https://www.github.com/googleapis/java-storage-nio/issues/205)) ([068002e](https://www.github.com/googleapis/java-storage-nio/commit/068002e1145418ecb848ed066346d1fc6ec14807))
* update dependency com.google.cloud:google-cloud-storage to v1.113.1 ([googleapis#212](https://www.github.com/googleapis/java-storage-nio/issues/212)) ([acc1fe8](https://www.github.com/googleapis/java-storage-nio/commit/acc1fe8f23c5926000c7a869ca9a71372850c46a))
* update dependency com.google.cloud:google-cloud-storage to v1.113.2 ([googleapis#266](https://www.github.com/googleapis/java-storage-nio/issues/266)) ([9d2c11d](https://www.github.com/googleapis/java-storage-nio/commit/9d2c11d009394f3f3ffd1b115b97b350aa64d1b7))
* update dependency com.google.guava:guava to v30 ([googleapis#263](https://www.github.com/googleapis/java-storage-nio/issues/263)) ([4e81dab](https://www.github.com/googleapis/java-storage-nio/commit/4e81daba421e0e42695203c6fe74670b32a3f576))
* update dependency org.mockito:mockito-core to v3.4.4 ([googleapis#170](https://www.github.com/googleapis/java-storage-nio/issues/170)) ([3e06bd5](https://www.github.com/googleapis/java-storage-nio/commit/3e06bd5b07065acb1b41a03ebbb862487c046eeb))
* update dependency org.mockito:mockito-core to v3.5.10 ([googleapis#203](https://www.github.com/googleapis/java-storage-nio/issues/203)) ([33fdc31](https://www.github.com/googleapis/java-storage-nio/commit/33fdc315a5b4bccdebb13262cbc5868011abe444))
* update dependency org.mockito:mockito-core to v3.5.11 ([googleapis#214](https://www.github.com/googleapis/java-storage-nio/issues/214)) ([575c308](https://www.github.com/googleapis/java-storage-nio/commit/575c30882ab84e1b2b1ce34d5176b4f8688a8136))
* update dependency org.mockito:mockito-core to v3.5.7 ([googleapis#194](https://www.github.com/googleapis/java-storage-nio/issues/194)) ([8cc7616](https://www.github.com/googleapis/java-storage-nio/commit/8cc76166baf3f5f49223bb8eafc8704679c4d427))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2 igorbernstein2 Awaiting requested review from igorbernstein2

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bigquerystorage, Java] Reconnect on "EOS on DATA frame" Internal Server Errors

4 participants

@pmakani @stephaniewang526 @googlebot @yoshi-kokoro