KEMBAR78
fix: add retry logic for readrows v1beta2 by pmakani · Pull Request #315 · googleapis/java-bigquerystorage · GitHub
Skip to content

Conversation

@pmakani
Copy link
Contributor

@pmakani pmakani commented May 29, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@pmakani pmakani requested a review from stephaniewang526 May 29, 2020 06:40
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 29, 2020
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #315 into master will increase coverage by 0.52%.
The diff coverage is 83.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #315      +/-   ##
============================================
+ Coverage     74.76%   75.28%   +0.52%     
- Complexity      410      438      +28     
============================================
  Files            48       51       +3     
  Lines          2754     2938     +184     
  Branches        126      151      +25     
============================================
+ Hits           2059     2212     +153     
- Misses          624      638      +14     
- Partials         71       88      +17     
Impacted Files Coverage Δ Complexity Δ
...v1beta2/stub/readrows/ApiResultRetryAlgorithm.java 78.26% <78.26%> (ø) 9.00 <9.00> (?)
...v1beta2/stub/readrows/ReadRowsAttemptCallable.java 78.94% <78.94%> (ø) 16.00 <16.00> (?)
...1beta2/stub/readrows/ReadRowsRetryingCallable.java 95.23% <95.23%> (ø) 2.00 <2.00> (?)
...storage/v1beta2/stub/EnhancedBigQueryReadStub.java 88.05% <96.55%> (+5.13%) 8.00 <3.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ddddd...7cbd7bd. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit cf1ab06 into googleapis:master May 29, 2020
@pmakani pmakani deleted the retry-logic-v1beta2 branch June 1, 2020 10:29
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 4, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
### [0.133.3](https://www.github.com/googleapis/java-bigquerystorage/compare/v0.133.2...v0.133.3) (2020-06-04)


### Bug Fixes

* add retry logic for readrows v1beta1 ([#314](https://www.github.com/googleapis/java-bigquerystorage/issues/314)) ([5290cec](https://www.github.com/googleapis/java-bigquerystorage/commit/5290cec444eaf1a21bcea543ac002276b82957e8))
* add retry logic for readrows v1beta2 ([#315](https://www.github.com/googleapis/java-bigquerystorage/issues/315)) ([cf1ab06](https://www.github.com/googleapis/java-bigquerystorage/commit/cf1ab06b4324219d2558bef6d30389dbf5d37ab7))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v1.116.1 ([#321](https://www.github.com/googleapis/java-bigquerystorage/issues/321)) ([c08116b](https://www.github.com/googleapis/java-bigquerystorage/commit/c08116b0fdabe256635bc8ba96b2c307f33a3998))
* update libraries-bom version ([dd21613](https://www.github.com/googleapis/java-bigquerystorage/commit/dd216134b98816f4b3cc6bd036eab01ebf04df35))


### Documentation

* **samples:** add codeowners file ([#317](https://www.github.com/googleapis/java-bigquerystorage/issues/317)) ([fc351c7](https://www.github.com/googleapis/java-bigquerystorage/commit/fc351c702ab0674f668a396559e18898f4653fdb))
* **samples:** add samples ([#309](https://www.github.com/googleapis/java-bigquerystorage/issues/309)) ([f142827](https://www.github.com/googleapis/java-bigquerystorage/commit/f142827253f7262f1d47d4c557c92076e1fa5fbe))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants