KEMBAR78
fix: geo type accepted change from bytes to string by yirutang · Pull Request #523 · googleapis/java-bigquerystorage · GitHub
Skip to content

fix: geo type accepted change from bytes to string #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2020
Merged

fix: geo type accepted change from bytes to string #523

merged 1 commit into from
Sep 8, 2020

Conversation

@yirutang
Copy link
Contributor

@yirutang yirutang commented Sep 4, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 4, 2020
@codecov
Copy link

codecov bot commented Sep 4, 2020 •
edited
Loading

Codecov Report

Merging #523 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #523   +/-   ##
=========================================
  Coverage     78.68%   78.68%           
  Complexity      662      662           
=========================================
  Files            59       59           
  Lines          3790     3790           
  Branches        255      255           
=========================================
  Hits           2982     2982           
  Misses          692      692           
  Partials        116      116
Impacted Files Coverage Δ Complexity Δ
...orage/v1alpha2/BQTableSchemaToProtoDescriptor.java 98.48% <100.00%> (ø) 8.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30d52e...45e291b. Read the comment docs.

@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Sep 5, 2020
@stephaniewang526 stephaniewang526 merged commit 94e6394 into googleapis:master Sep 8, 2020
@yirutang yirutang deleted the jsonwriter branch December 10, 2020 23:30
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@release-please
chore: release 0.122.13-SNAPSHOT (googleapis#523)
d878eff 
🤖 I have created a release \*beep\* \*boop\*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yirutang @stephaniewang526