KEMBAR78
test(Java): Jstocklass stress testing by JacobStocklass · Pull Request #899 · googleapis/java-bigquerystorage · GitHub
Skip to content

test(Java): Jstocklass stress testing #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 9, 2021
Merged

test(Java): Jstocklass stress testing #899

merged 20 commits into from
Mar 9, 2021

Conversation

@JacobStocklass
Copy link
Contributor

This is a very basic set of tests that serve as a placeholder for stress tests. I've named the folder "st" for stress test similar to how "it" was named for integration tests.

@JacobStocklass JacobStocklass requested review from a team and shollyman March 1, 2021 18:11
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Mar 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2021
@JacobStocklass JacobStocklass changed the title Jstocklass stress testing Jstocklass Stress testing read API starter code. Mar 1, 2021
@JacobStocklass JacobStocklass changed the title Jstocklass Stress testing read API starter code. feat(Java): Jstocklass stress testing Mar 1, 2021
@stephaniewang526
Copy link
Contributor

I think this is a test instead of feat

@JacobStocklass JacobStocklass reopened this Mar 1, 2021
@JacobStocklass JacobStocklass changed the title feat(Java): Jstocklass stress testing test(Java): Jstocklass stress testing Mar 1, 2021
@JacobStocklass JacobStocklass requested a review from yirutang March 1, 2021 19:27
yirutang
yirutang reviewed Mar 1, 2021
View reviewed changes
@JacobStocklass JacobStocklass requested a review from gnanda March 2, 2021 00:02
gnanda
gnanda suggested changes Mar 2, 2021
View reviewed changes
@stephaniewang526
Copy link
Contributor

To fix formatting errors, run mvn com.coveo:fmt-maven-plugin:format -- this will clear the lint error.

@JacobStocklass
Copy link
Contributor Author

Currently blocked by CI failures. For some reason the tests want to use cloudtop-prod for the new test and it is causing failures due to not having permission. Unsure how to set the project to bigquerytestdefault in this environment. On my local environment mvn install fails but mvn install -DGOOGLE_CLOUD_PROJECT=bigquerytestdefault works perfectly fine.

@stephaniewang526
Copy link
Contributor

To fix formatting errors, run mvn com.coveo:fmt-maven-plugin:format -- this will clear the lint error.

@JacobStocklass PTAL

@codecov
Copy link

codecov bot commented Mar 3, 2021 •
edited
Loading

Codecov Report

Merging #899 (d385995) into master (814c7dd) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #899      +/-   ##
============================================
- Coverage     81.14%   80.99%   -0.16%     
- Complexity      996     1021      +25     
============================================
  Files            74       76       +2     
  Lines          5347     5556     +209     
  Branches        415      426      +11     
============================================
+ Hits           4339     4500     +161     
- Misses          838      879      +41     
- Partials        170      177       +7
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/bigquery/storage/v1beta2/Waiter.java 56.04% <0.00%> (-16.90%) 12.00% <0.00%> (-6.00%)
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 80.39% <0.00%> (-3.93%) 34.00% <0.00%> (-3.00%)
...oud/bigquery/storage/v1beta2/JsonStreamWriter.java 76.52% <0.00%> (-2.47%) 14.00% <0.00%> (-1.00%)
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 83.25% <0.00%> (-1.78%) 33.00% <0.00%> (-5.00%)
...google/cloud/bigquery/storage/v1alpha2/Waiter.java 55.95% <0.00%> (-1.20%) 12.00% <0.00%> (-2.00%)
...bigquery/storage/v1/stub/GrpcBigQueryReadStub.java 89.53% <0.00%> (ø) 10.00% <0.00%> (ø%)
...ery/storage/v1beta2/stub/GrpcBigQueryReadStub.java 89.53% <0.00%> (ø) 10.00% <0.00%> (ø%)
...ry/storage/v1beta2/stub/GrpcBigQueryWriteStub.java 93.24% <0.00%> (ø) 15.00% <0.00%> (ø%)
...y/storage/v1alpha2/stub/GrpcBigQueryWriteStub.java 93.50% <0.00%> (ø) 15.00% <0.00%> (ø%)
.../storage/v1beta1/stub/GrpcBigQueryStorageStub.java 92.80% <0.00%> (ø) 12.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 814c7dd...24c2154. Read the comment docs.

@JacobStocklass
Copy link
Contributor Author

Currently blocked by CI failures. For some reason the tests want to use cloudtop-prod for the new test and it is causing failures due to not having permission. Unsure how to set the project to bigquerytestdefault in this environment. On my local environment mvn install fails but mvn install -DGOOGLE_CLOUD_PROJECT=bigquerytestdefault works perfectly fine.

The problem was naming the test ST instead of IT

gnanda
gnanda reviewed Mar 4, 2021
View reviewed changes
@JacobStocklass JacobStocklass force-pushed the jstocklass-stress-testing branch from ff1fd67 to 24c2154 Compare March 4, 2021 23:25
@JacobStocklass JacobStocklass merged commit e8255e7 into googleapis:master Mar 9, 2021
@JacobStocklass JacobStocklass deleted the jstocklass-stress-testing branch March 9, 2021 18:33
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@renovate-bot
deps: update dependency com.google.apis:google-api-services-storage t…
52d2969 
…o v1-rev20220509-1.32.1 (googleapis#899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yirutang yirutang yirutang approved these changes

@shollyman shollyman Awaiting requested review from shollyman

+2 more reviewers

@gnanda gnanda gnanda approved these changes

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JacobStocklass @stephaniewang526 @gnanda @yirutang