KEMBAR78
fix: Cleanup JsonWriter bytes conversion code and add some test coverage by yirutang · Pull Request #984 · googleapis/java-bigquerystorage · GitHub
Skip to content

fix: Cleanup JsonWriter bytes conversion code and add some test coverage #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2021
Merged

fix: Cleanup JsonWriter bytes conversion code and add some test coverage #984

merged 2 commits into from
Apr 7, 2021

Conversation

@yirutang
Copy link
Contributor

@yirutang yirutang commented Apr 7, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested a review from a team April 7, 2021 00:18
@yirutang yirutang requested a review from a team as a code owner April 7, 2021 00:18
@yirutang yirutang requested a review from steffnay April 7, 2021 00:18
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Apr 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2021
@yirutang yirutang requested a review from JacobStocklass April 7, 2021 00:18
stephaniewang526
stephaniewang526 suggested changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@stephaniewang526 stephaniewang526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests after failing. PTAL @yirutang

JacobStocklass
JacobStocklass approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@JacobStocklass JacobStocklass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a lot better with Bytes being handled as just JSONArray instead of JSONArray or String like I had it earlier. Makes the testing a lot less confusing.

@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 7, 2021
@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #984 (4a7e76e) into master (5c8c4e7) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #984      +/-   ##
============================================
- Coverage     81.03%   80.99%   -0.04%     
+ Complexity     1046     1045       -1     
============================================
  Files            78       78              
  Lines          5669     5668       -1     
  Branches        436      435       -1     
============================================
- Hits           4594     4591       -3     
- Misses          889      890       +1     
- Partials        186      187       +1
Impacted Files Coverage Δ Complexity Δ
...orage/v1alpha2/BQTableSchemaToProtoDescriptor.java 98.48% <100.00%> (ø) 8.00 <0.00> (ø)
...d/bigquery/storage/v1beta2/JsonToProtoMessage.java 97.10% <100.00%> (-0.03%) 46.00 <1.00> (-1.00)
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 79.95% <0.00%> (-0.44%) 34.00% <0.00%> (ø%)
...bigquery/storage/v1alpha2/BigQueryWriteClient.java 80.51% <0.00%> (ø) 38.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c8c4e7...4a7e76e. Read the comment docs.

@gcf-merge-on-green gcf-merge-on-green bot merged commit e43df34 into googleapis:master Apr 7, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 7, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 9, 2021
@release-please
chore: release 1.18.0 (#981)
e8ca0ae 
🤖 I have created a release \*beep\* \*boop\*
---
## [1.18.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.17.0...v1.18.0) (2021-04-09)


### Features

* add deprecated annotation and tag to bq storage alpha api ([#978](https://www.github.com/googleapis/java-bigquerystorage/issues/978)) ([c7da342](https://www.github.com/googleapis/java-bigquerystorage/commit/c7da34252ee8c243be3ce737d03e1e12f10a5eba))
* re-generated to pick up changes from googleapis. ([#982](https://www.github.com/googleapis/java-bigquerystorage/issues/982)) ([17bfbd8](https://www.github.com/googleapis/java-bigquerystorage/commit/17bfbd8dffd854356ea503adf3a6e065f1e1a4ee))


### Bug Fixes

* Cleanup JsonWriter bytes conversion code and add some test coverage ([#984](https://www.github.com/googleapis/java-bigquerystorage/issues/984)) ([e43df34](https://www.github.com/googleapis/java-bigquerystorage/commit/e43df3403c4d7644032cef6e1f1cf59e6ec1b5eb))


### Documentation

* update region tag for the storage quickstart ([#985](https://www.github.com/googleapis/java-bigquerystorage/issues/985)) ([1d0d6c3](https://www.github.com/googleapis/java-bigquerystorage/commit/1d0d6c3a877943b83775430d5a2bf7fcd24a1f21))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v1.127.12 ([#986](https://www.github.com/googleapis/java-bigquerystorage/issues/986)) ([d39bd79](https://www.github.com/googleapis/java-bigquerystorage/commit/d39bd79a69e987baa7721b907cdccb59d1ea4a74))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.21.0 ([#987](https://www.github.com/googleapis/java-bigquerystorage/issues/987)) ([4fa3dbb](https://www.github.com/googleapis/java-bigquerystorage/commit/4fa3dbba64586f6bf943ba67f225fad1b994e5a7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@yirutang yirutang deleted the bytes branch April 30, 2021 19:00
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@renovate-bot
test(deps): update dependency org.mockito:mockito-core to v4.7.0 (goo…
5df788a 
…gleapis#984)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steffnay steffnay Awaiting requested review from steffnay

2 more reviewers

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

@JacobStocklass JacobStocklass JacobStocklass approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yirutang @stephaniewang526 @JacobStocklass @yoshi-kokoro