KEMBAR78
fix: use universe domain when creating the monitoring client by mutianf · Pull Request #2570 · googleapis/java-bigtable · GitHub
Skip to content

fix: use universe domain when creating the monitoring client #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

fix: use universe domain when creating the monitoring client #2570

merged 2 commits into from
Apr 28, 2025

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented Apr 25, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested review from a team as code owners April 25, 2025 17:58
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Apr 25, 2025
@mutianf mutianf merged commit 3b51e12 into googleapis:main Apr 28, 2025
30 of 31 checks passed
@mutianf mutianf deleted the tpc-metrics branch April 28, 2025 15:15
@release-please release-please bot mentioned this pull request Apr 28, 2025
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 28, 2025
@release-please
chore(main): release 2.58.0 (#2564)
0af7d03 
🤖 I have created a release *beep* *boop*
---


## [2.58.0](https://togithub.com/googleapis/java-bigtable/compare/v2.57.3...v2.58.0) (2025-04-28)


### Features

* Add deletion_protection support for LVs ([43c97a3](https://togithub.com/googleapis/java-bigtable/commit/43c97a3f430ee4ee90d46b3685ae50f13949831c))
* **bigtable:** Add integration tests for Materialized/Logical Views ([#2518](https://togithub.com/googleapis/java-bigtable/issues/2518)) ([4d3a7e6](https://togithub.com/googleapis/java-bigtable/commit/4d3a7e675b60ba6a3225a45b7463edff279f9bc4))


### Bug Fixes

* **deps:** Update the Java code generator (gapic-generator-java) to 2.56.2 ([43c97a3](https://togithub.com/googleapis/java-bigtable/commit/43c97a3f430ee4ee90d46b3685ae50f13949831c))
* Fix retry info algorithm setting ([#2562](https://togithub.com/googleapis/java-bigtable/issues/2562)) ([c424ccb](https://togithub.com/googleapis/java-bigtable/commit/c424ccba72a191609dc726ed67d03f0d330015fc))
* Use universe domain when creating the monitoring client ([#2570](https://togithub.com/googleapis/java-bigtable/issues/2570)) ([3b51e12](https://togithub.com/googleapis/java-bigtable/commit/3b51e1206a4f83078625705ed8d8a899839af1a9))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mutianf @igorbernstein2