chore: integrate channel pool fixes #2599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I8b8da7b1a5d7a6afb2f227809a3e003163060ebe
Change-Id: I0e4e1f056960ae55d2f89a372e92231133e61528
Change-Id: I4867ac58e1aa77f65b9b14eb666c1e1bb3d24cc5
product-auto-label
bot
added
size: m
Change-Id: I028776c18221c909b0bcdfffff62a1d77ee7f469
igorbernstein2
requested changes
Jun 12, 2025
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java
Show resolved
Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Show resolved
Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java
Show resolved
Hide resolved
...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java
Outdated
Show resolved
Hide resolved
...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java
Outdated
Show resolved
Hide resolved
...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java
Outdated
Show resolved
Hide resolved
...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java
Show resolved
Hide resolved
igorbernstein2
changed the title
Change-Id: I8fc15d7d028c773385cd557aa6d2fb3a2453a1da
product-auto-label
bot
added
size: l
...d-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/utils/ChannelPoolSettingsCopier.java
Outdated
Show resolved
Hide resolved
Comment on lines
11
to
12
| if (original == null) { | ||
| return null; |
There was a problem hiding this comment.
when do we have to deal with null?
There was a problem hiding this comment.
It is not currently being called with anything that is null but perhaps some future caller could? Maybe overly cautious.
...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/gaxx/utils/ChannelPoolCopyTest.java
Outdated
Show resolved
Hide resolved
...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/gaxx/utils/ChannelPoolCopyTest.java
Outdated
Show resolved
Hide resolved
…fine test Change-Id: I90bb9d20a10e9b930507bf260b8bb77e2628abe2
Change-Id: I7beff1ffdde48c3417f5d2b362e0ad556ba0669c
...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java
Outdated
Show resolved
Hide resolved
...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/gaxx/utils/ChannelPoolCopyTest.java
Outdated
Show resolved
Hide resolved
Change-Id: Ifd84786b224109b73b6acb13fd08c3f892a48f12
Change-Id: I65972734a494cbf5cece251edfb871d493a48d1c
igorbernstein2
previously approved these changes
Jun 16, 2025
mutianf
reviewed
Jun 16, 2025
...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java
Show resolved
Hide resolved
...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java
Outdated
Show resolved
Hide resolved
...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java
Outdated
Show resolved
Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java
Outdated
Show resolved
Hide resolved
mutianf
reviewed
Jun 16, 2025
...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java
Show resolved
Hide resolved
mutianf
previously approved these changes
Jun 16, 2025
mutianf
previously approved these changes
Jun 16, 2025
Change-Id: I0bdea5e891b27f87972b0cf4f7023f10136f627a
mutianf
approved these changes
Jun 16, 2025
|
/gcbrun |
mutianf
added
the
automerge
yoshi-kokoro
removed
the
kokoro:run
gcf-merge-on-green
bot
merged commit a3bb43d
into
googleapis:main
30 of 33 checks passed
gcf-merge-on-green
bot
removed
the
automerge
nicholsl
added a commit
to nicholsl/java-bigtable
that referenced
this pull request
Jul 16, 2025
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/2601) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [ ] Rollback plan is reviewed and LGTMed - [ ] All new data plane features have a completed end to end testing plan Fixes googleapis#2601 ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2601 ☕️
If you write sample code, please follow the samples format.