feat: Load balancing options for BigtableChannelPool #2667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
neilw4
force-pushed
the
load-balancer
branch
from
f29d1e6 to
42fecb6
Compare
product-auto-label
bot
added
size: m
neilw4
force-pushed
the
load-balancer
branch
from
42fecb6 to
e86999b
Compare
product-auto-label
bot
added
size: l
neilw4
force-pushed
the
load-balancer
branch
from
e86999b to
8b4beeb
Compare
product-auto-label
bot
added
size: m
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Show resolved
Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
...-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPoolSettings.java
Outdated
Show resolved
Hide resolved
...-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPoolSettings.java
Show resolved
Hide resolved
neilw4
force-pushed
the
load-balancer
branch
from
8b4beeb to
74c14f5
Compare
There was a problem hiding this comment.
Looks good overall. Left a couple of nits.
My only outstanding concern is for the least loaded algos. I think we need some protection for channels that are failing fast. So I think we need to track moving error ratios and if ratio crosses some threshold it short circuits least loaded comparison.
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
...-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPoolSettings.java
Show resolved
Hide resolved
neilw4
force-pushed
the
load-balancer
branch
from
74c14f5 to
78370e0
Compare
igorbernstein2
previously approved these changes
Sep 19, 2025
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
igorbernstein2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
neilw4
commented
Sep 19, 2025
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
neilw4
force-pushed
the
load-balancer
branch
from
813336f to
0ae0192
Compare
igorbernstein2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
igorbernstein2
approved these changes
Sep 22, 2025
mutianf
approved these changes
Sep 22, 2025
igorbernstein2
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
merged commit 5adaa84
into
googleapis:main
23 of 25 checks passed
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 25, 2025
🤖 I have created a release *beep* *boop* --- ## [2.67.0](https://togithub.com/googleapis/java-bigtable/compare/v2.66.0...v2.67.0) (2025-09-24) ### Features * Idle channel eviction ([#2651](https://togithub.com/googleapis/java-bigtable/issues/2651)) ([70c05c9](https://togithub.com/googleapis/java-bigtable/commit/70c05c9c09a63c53818384d2a66c622c9b95e00e)) * Load balancing options for BigtableChannelPool ([#2667](https://togithub.com/googleapis/java-bigtable/issues/2667)) ([5adaa84](https://togithub.com/googleapis/java-bigtable/commit/5adaa84d80df08779da7c36a50de4632049cfe96)) ### Bug Fixes * Add missing break; to PROTO and ENUM value type check ([#2672](https://togithub.com/googleapis/java-bigtable/issues/2672)) ([337e432](https://togithub.com/googleapis/java-bigtable/commit/337e4325f6cb5d11309ec5f33550d47d97cbe3c3)) * Remove beta api annotation for query paginator ([#2660](https://togithub.com/googleapis/java-bigtable/issues/2660)) ([f68a1fa](https://togithub.com/googleapis/java-bigtable/commit/f68a1fae49b701d1fb9942e2af2fa84a1e5b508a)) ### Dependencies * Update shared dependencies ([#2679](https://togithub.com/googleapis/java-bigtable/issues/2679)) ([a5b8260](https://togithub.com/googleapis/java-bigtable/commit/a5b82609c365ae4792ed822e59039c1a046ef3ff)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiments have shown that least-in-flight balancing is particularly effective when some channels or backends have problems.
Depends on: #2651