KEMBAR78
feat: add keepalive changes in java client library by sushanb · Pull Request #409 · googleapis/java-bigtable · GitHub
Skip to content

Conversation

@sushanb
Copy link
Contributor

@sushanb sushanb commented Sep 3, 2020

This will enable to detect the dead peer tcp connection within (10+10) seconds and start a new one.

Fixes #408 408☕️

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 3, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #409 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #409      +/-   ##
============================================
+ Coverage     80.43%   80.45%   +0.02%     
  Complexity     1114     1114              
============================================
  Files           105      105              
  Lines          6900     6914      +14     
  Branches        369      369              
============================================
+ Hits           5550     5563      +13     
- Misses         1150     1152       +2     
+ Partials        200      199       -1     
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/bigtable/emulator/v2/Emulator.java 60.33% <100.00%> (+1.20%) 14.00 <0.00> (ø)
...e/cloud/bigtable/data/v2/BigtableDataSettings.java 65.71% <100.00%> (+2.07%) 7.00 <0.00> (ø)
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 96.86% <100.00%> (+0.05%) 22.00 <0.00> (ø)
...gle/cloud/bigtable/data/v2/BigtableDataClient.java 94.02% <0.00%> (ø) 39.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e17f0a...ea70755. Read the comment docs.

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Sep 4, 2020
@sushanb sushanb changed the title Add keepalive changes in java client library feat: add keepalive changes in java client library Sep 9, 2020
@sushanb
Copy link
Contributor Author

sushanb commented Sep 10, 2020

@igorbernstein2 @kolea2 can you review? I do not think I can add you as reviewers.

@igorbernstein2 igorbernstein2 self-requested a review September 16, 2020 14:19
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 6, 2020
@igorbernstein2 igorbernstein2 merged commit edbcde1 into googleapis:master Oct 6, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 6, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.16.0](https://www.github.com/googleapis/java-bigtable/compare/v1.15.0...v1.16.0) (2020-10-06)


### Features

* add keepalive changes in java client library ([#409](https://www.github.com/googleapis/java-bigtable/issues/409)) ([edbcde1](https://www.github.com/googleapis/java-bigtable/commit/edbcde1a5b22317319803cb57401252aac6d580d))
* include User agent ([#404](https://www.github.com/googleapis/java-bigtable/issues/404)) ([0cd71b5](https://www.github.com/googleapis/java-bigtable/commit/0cd71b59305cd7a336c223faff68402a8bee4639))
* Ability to extend UserAgent string (via gax upgrade)

### Bug Fixes

* **test:** Clean up tests ([#439](https://www.github.com/googleapis/java-bigtable/issues/439)) ([c5c881b](https://www.github.com/googleapis/java-bigtable/commit/c5c881bb956860a393c2a7f34d0d790a23d270af))
* Add documentation to bulkReadRows that each batch will process t… ([#410](https://www.github.com/googleapis/java-bigtable/issues/410)) ([71dc8e3](https://www.github.com/googleapis/java-bigtable/commit/71dc8e3419fbb49d48bb7a3fd984d24e24661c81))
* Filters should be serializable ([#397](https://www.github.com/googleapis/java-bigtable/issues/397)) ([57edfde](https://www.github.com/googleapis/java-bigtable/commit/57edfde5eace28d50ec777e14589c9747616f0a8))
* RowCells are not actually serializeable ([#407](https://www.github.com/googleapis/java-bigtable/issues/407)) ([39e17cc](https://www.github.com/googleapis/java-bigtable/commit/39e17cc17c438f2d665875f9ff2b2cdf984e37b7))
* Fix race condition in Batcher.close() (via gax upgrade)


### Dependencies

* update dependency com.google.cloud:google-cloud-conformance-tests to v0.0.12 ([#415](https://www.github.com/googleapis/java-bigtable/issues/415)) ([7b3713a](https://www.github.com/googleapis/java-bigtable/commit/7b3713a8935b2f0b1ca57d189e9e0363506b28a1))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.0 ([#428](https://www.github.com/googleapis/java-bigtable/issues/428)) ([373032e](https://www.github.com/googleapis/java-bigtable/commit/373032e93b838cbc0ccab7dc45cd61b3b973542a))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.1 ([#443](https://www.github.com/googleapis/java-bigtable/issues/443)) ([939fefa](https://www.github.com/googleapis/java-bigtable/commit/939fefa819d09885489d9faeedadc74ee2b0e1b9))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.1 ([#427](https://www.github.com/googleapis/java-bigtable/issues/427)) ([5175e28](https://www.github.com/googleapis/java-bigtable/commit/5175e28f5ce69f6fb3ed14131c1cfd26dbc47bb9))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ad548 pushed a commit to ad548/java-bigtable that referenced this pull request Mar 13, 2021
* feat: Add keepalive logic in bigtable data client

* fix: code formatting

* fix: mvn formatting

* fix: setting in emulator

* feat: add keep alive in enhanced stub as well
ad548 pushed a commit to ad548/java-bigtable that referenced this pull request Mar 13, 2021
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.16.0](https://www.github.com/googleapis/java-bigtable/compare/v1.15.0...v1.16.0) (2020-10-06)


### Features

* add keepalive changes in java client library ([googleapis#409](https://www.github.com/googleapis/java-bigtable/issues/409)) ([edbcde1](https://www.github.com/googleapis/java-bigtable/commit/edbcde1a5b22317319803cb57401252aac6d580d))
* include User agent ([googleapis#404](https://www.github.com/googleapis/java-bigtable/issues/404)) ([0cd71b5](https://www.github.com/googleapis/java-bigtable/commit/0cd71b59305cd7a336c223faff68402a8bee4639))
* Ability to extend UserAgent string (via gax upgrade)

### Bug Fixes

* **test:** Clean up tests ([googleapis#439](https://www.github.com/googleapis/java-bigtable/issues/439)) ([c5c881b](https://www.github.com/googleapis/java-bigtable/commit/c5c881bb956860a393c2a7f34d0d790a23d270af))
* Add documentation to bulkReadRows that each batch will process t… ([googleapis#410](https://www.github.com/googleapis/java-bigtable/issues/410)) ([71dc8e3](https://www.github.com/googleapis/java-bigtable/commit/71dc8e3419fbb49d48bb7a3fd984d24e24661c81))
* Filters should be serializable ([googleapis#397](https://www.github.com/googleapis/java-bigtable/issues/397)) ([57edfde](https://www.github.com/googleapis/java-bigtable/commit/57edfde5eace28d50ec777e14589c9747616f0a8))
* RowCells are not actually serializeable ([googleapis#407](https://www.github.com/googleapis/java-bigtable/issues/407)) ([39e17cc](https://www.github.com/googleapis/java-bigtable/commit/39e17cc17c438f2d665875f9ff2b2cdf984e37b7))
* Fix race condition in Batcher.close() (via gax upgrade)


### Dependencies

* update dependency com.google.cloud:google-cloud-conformance-tests to v0.0.12 ([googleapis#415](https://www.github.com/googleapis/java-bigtable/issues/415)) ([7b3713a](https://www.github.com/googleapis/java-bigtable/commit/7b3713a8935b2f0b1ca57d189e9e0363506b28a1))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.0 ([googleapis#428](https://www.github.com/googleapis/java-bigtable/issues/428)) ([373032e](https://www.github.com/googleapis/java-bigtable/commit/373032e93b838cbc0ccab7dc45cd61b3b973542a))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.1 ([googleapis#443](https://www.github.com/googleapis/java-bigtable/issues/443)) ([939fefa](https://www.github.com/googleapis/java-bigtable/commit/939fefa819d09885489d9faeedadc74ee2b0e1b9))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.1 ([googleapis#427](https://www.github.com/googleapis/java-bigtable/issues/427)) ([5175e28](https://www.github.com/googleapis/java-bigtable/commit/5175e28f5ce69f6fb3ed14131c1cfd26dbc47bb9))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add keepalive setting in client library.

3 participants