KEMBAR78
test(fix): use consistent endpoint for all table admin clients in test by liubonan · Pull Request #533 · googleapis/java-bigtable · GitHub
Skip to content

test(fix): use consistent endpoint for all table admin clients in test #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2020
Merged

test(fix): use consistent endpoint for all table admin clients in test #533

merged 1 commit into from
Nov 16, 2020

Conversation

@liubonan
Copy link
Contributor

@liubonan liubonan commented Nov 12, 2020 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@liubonan liubonan requested a review from a team as a code owner November 12, 2020 23:14
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2020
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020 •
edited
Loading

Codecov Report

Merging #533 (4398c8a) into master (0b02977) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #533      +/-   ##
============================================
- Coverage     81.28%   81.27%   -0.01%     
  Complexity     1129     1129              
============================================
  Files           106      106              
  Lines          7047     7045       -2     
  Branches        370      370              
============================================
- Hits           5728     5726       -2     
  Misses         1119     1119              
  Partials        200      200
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigtable/data/v2/BigtableDataSettings.java 71.42% <0.00%> (-0.41%) 8.00% <0.00%> (ø%)
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 96.06% <0.00%> (-0.02%) 23.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b02977...4398c8a. Read the comment docs.

@kolea2 kolea2 merged commit 5b95440 into googleapis:master Nov 16, 2020
ad548 pushed a commit to ad548/java-bigtable that referenced this pull request Mar 13, 2021
@liubonan @ad548
test(fix): use consistent endpoint for all table admin clients in test (
0107297 
googleapis#533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liubonan @kolea2