KEMBAR78
fix: revert conformance test version by mutianf · Pull Request #846 · googleapis/java-bigtable · GitHub
Skip to content

fix: revert conformance test version #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2021
Merged

fix: revert conformance test version #846

merged 1 commit into from
Jun 1, 2021

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented May 27, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@mutianf mutianf requested review from a team as code owners May 27, 2021 21:47
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label May 27, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2021
@mutianf mutianf added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 27, 2021
@mutianf
Copy link
Contributor Author

mutianf commented May 27, 2021

Note: if we can't figure out why kokoro tests are failing and need to run the tests for release then we can merge this pr.

@mutianf mutianf removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 27, 2021
@igorbernstein2 igorbernstein2 merged commit b23b0d7 into googleapis:master Jun 1, 2021
igorbernstein2 added a commit that referenced this pull request Jun 2, 2021
@igorbernstein2
Revert "fix: revert conformance test version (#846)"
7690120 
This reverts commit b23b0d7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mutianf @igorbernstein2