fix: declare gson as runtime rather than test #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing similar issues as googleapis/java-pubsub#1239
product-auto-label
bot
added
the
api: firestore
alicejli
approved these changes
Aug 19, 2022
blakeli0
approved these changes
Aug 19, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 19, 2022
🤖 I have created a release *beep* *boop* --- ## [3.4.1](v3.4.0...v3.4.1) (2022-08-19) ### Bug Fixes * declare gson as runtime rather than test ([#1004](#1004)) ([e37e997](e37e997)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
cherylEnkidu
pushed a commit
that referenced
this pull request
Dec 11, 2023
Fixing similar issues as googleapis/java-pubsub#1239
cherylEnkidu
pushed a commit
that referenced
this pull request
Dec 11, 2023
🤖 I have created a release *beep* *boop* --- ## [3.4.1](v3.4.0...v3.4.1) (2022-08-19) ### Bug Fixes * declare gson as runtime rather than test ([#1004](#1004)) ([e37e997](e37e997)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing similar issues as googleapis/java-pubsub#1239.
In this case, declaring gson as test causes the flatten-maven-plugin to exclude gson from other dependency declarations.