KEMBAR78
feat: Enable `OR` Query support. by ehsannas · Pull Request #1007 · googleapis/java-firestore · GitHub
Skip to content

Conversation

@ehsannas
Copy link
Contributor

No description provided.

@ehsannas ehsannas requested a review from a team as a code owner August 10, 2022 16:17
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Aug 10, 2022
@ehsannas ehsannas requested a review from a team as a code owner August 10, 2022 16:19
@ehsannas ehsannas requested a review from MarkDuckworth August 10, 2022 20:59
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions.

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Nov 10, 2022
@ehsannas ehsannas changed the title Remove TODOs and add tests for OR Query support. feat: Remove TODOs and add tests for OR Query support. Jan 10, 2023
@ehsannas ehsannas added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 3, 2023
@ehsannas ehsannas changed the title feat: Remove TODOs and add tests for OR Query support. feat: Enable OR Query support. Mar 3, 2023
@ehsannas ehsannas added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 4, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2023
@ehsannas ehsannas merged commit e502cd4 into main Mar 6, 2023
@ehsannas ehsannas deleted the ehsann/or-query branch March 6, 2023 17:44
cherylEnkidu pushed a commit that referenced this pull request Dec 11, 2023
* Remove TODOs and add tests for OR Query support.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Address comments and backport a new test.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Target backend for integration tests.

* Fix: uninitialized 'firestore' variable.

* Add the docs.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add test dependency.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Remove tests that require composite index and unsupported cases.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Remove the 'hide' annotation.

* Rearrange/add tests.

* remove duplicate test which is run only against emulator.

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: meredithslota <meredithslota@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants