KEMBAR78
ci: enable ITQueryCountTest in CI, since the project is whitelisted for COUNT by dconeybe · Pull Request #1040 · googleapis/java-firestore · GitHub
Skip to content

ci: enable ITQueryCountTest in CI, since the project is whitelisted for COUNT #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2022
Merged

ci: enable ITQueryCountTest in CI, since the project is whitelisted for COUNT #1040

merged 3 commits into from
Sep 23, 2022

Conversation

@dconeybe
Copy link
Contributor

No description provided.

@dconeybe dconeybe self-assigned this Sep 22, 2022
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Sep 22, 2022
@dconeybe dconeybe changed the title ci: enable ITQueryCountTest in CI, since the project is whitelists for COUNT ci: enable ITQueryCountTest in CI, since the project is whitelisted for COUNT Sep 22, 2022
@dconeybe
Copy link
Contributor Author

dconeybe commented Sep 22, 2022 •
edited
Loading

aggregateQueryInATransactionShouldLockTheCountedDocuments is failing on kokoro:

java.lang.AssertionError: expected java.util.concurrent.ExecutionException to be thrown, but nothing was thrown
	at com.google.cloud.firestore.ITQueryCountTest.aggregateQueryInATransactionShouldLockTheCountedDocuments(ITQueryCountTest.java:238)

I need to check if this is a bug in the backend or a faulty test. This test passes against the Firestore emulator.

Here is the line in the test that is failing:

java-firestore/google-cloud-firestore/src/test/java/com/google/cloud/firestore/ITQueryCountTest.java

Line 238 in a7e90dd

executionException = assertThrows(ExecutionException.class, documentSetTask::get);

I've opened b/248152832 to investigate.

@dconeybe dconeybe marked this pull request as ready for review September 22, 2022 04:11
@dconeybe dconeybe requested a review from a team as a code owner September 22, 2022 04:11
@dconeybe dconeybe mentioned this pull request Sep 22, 2022
Draft
@dconeybe
Copy link
Contributor Author

I've just disabled aggregateQueryInATransactionShouldLockTheCountedDocuments for now, so at least the rest of the tests can be run. I've opened #1043 to investigate and re-enable it.

@dconeybe dconeybe requested a review from ehsannas September 22, 2022 04:37
@ehsannas ehsannas added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2022
@dconeybe dconeybe merged commit e5ccf88 into main Sep 23, 2022
@dconeybe dconeybe deleted the dconeybe/EnableITQueryCountTestInCI branch September 23, 2022 02:28
cherylEnkidu pushed a commit that referenced this pull request Dec 11, 2023
@dconeybe @cherylEnkidu
ci: enable ITQueryCountTest in CI, since the project is whitelisted f…
71fb072 
…or COUNT (#1040)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@ehsannas ehsannas

@dconeybe dconeybe

Labels

api: firestore Issues related to the googleapis/java-firestore API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dconeybe @ehsannas