test: Fix distracting NPE from ExampleFirestoreWriteReadTest.tearDown() #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconeybe
added
the
api: firestore
tom-andersen
approved these changes
Oct 12, 2022
dconeybe
deleted the
dconeybe/SamplesFixExampleFirestoreWriteReadTestTearDownException
branch
cherylEnkidu
pushed a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ExampleFirestoreWriteReadTest.tearDown()method assumes that the static variablesfirestoreandcollectionIdare not null; however, ifsetUp()failed with an exception, then these variables are null. In such a case,tearDown()throws aNullPointerException. This NPE is just added noise that distracts from the real issue, thatsetUp()failed. This PR fixes this noisy NPE by simply performing a null check before using these static variables.