KEMBAR78
chore: mark native image checks as required by mpeddada1 · Pull Request #979 · googleapis/java-firestore · GitHub
Skip to content

chore: mark native image checks as required #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2022
Merged

chore: mark native image checks as required #979

merged 1 commit into from
Jul 11, 2022

Conversation

@mpeddada1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@mpeddada1 mpeddada1 requested review from a team as code owners June 29, 2022 14:26
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/sync-repo-settings.yaml

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Jun 29, 2022
@mpeddada1 mpeddada1 requested a review from ehsannas July 8, 2022 18:58
@alicejli alicejli merged commit c3a2ff2 into main Jul 11, 2022
@alicejli alicejli deleted the require-graal-check branch July 11, 2022 21:50
cherylEnkidu pushed a commit that referenced this pull request Dec 11, 2023
@mpeddada1 @cherylEnkidu
chore: add native image checks as required (#979)
4197d6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsannas ehsannas Awaiting requested review from ehsannas

1 more reviewer

@alicejli alicejli alicejli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: firestore Issues related to the googleapis/java-firestore API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpeddada1 @alicejli