feat: Support AbortIncompleteMultipartUpload LifecycleAction #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
sydney-munro
changed the title
sydney-munro
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sydney-munro
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sydney-munro
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
frankyn
suggested changes
Apr 13, 2022
google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
Outdated
Show resolved
Hide resolved
| try { | ||
| assertEquals(AbortIncompleteMPUAction.TYPE, lifecycleRule.getAction().getActionType()); | ||
| assertEquals(1, lifecycleRule.getCondition().getAge().intValue()); | ||
| } finally { |
There was a problem hiding this comment.
ah interesting; didn't think of wrapping asserts with a try {} so you can do clean up afterwards, clever.
frankyn
suggested changes
Apr 14, 2022
google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
Show resolved
Hide resolved
…ecycle action tests
product-auto-label
bot
added
size: m
sydney-munro
commented
Apr 14, 2022
| setStorageClassLifecycleRule.getAction().getStorageClass()); | ||
| assertTrue(setStorageClassLifecycleRule.getCondition().getIsLive()); | ||
| assertEquals(10, setStorageClassLifecycleRule.getCondition().getNumNewerVersions().intValue()); | ||
| assertTrue( |
There was a problem hiding this comment.
just added these in since I didn't see us testing all the cases of the fromPb switch statement.
frankyn
approved these changes
Apr 15, 2022
suztomo
pushed a commit
to suztomo/java-storage
that referenced
this pull request
Apr 21, 2022
shaffeeullah
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1339 ☕️
If you write sample code, please follow the samples format.