fix: update RecoveryFileManager to allow distinct files for multiple invocations of equivalent info #2207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
…invocations of equivalent info When creating a new recovery file it is important that distinct recovery files be created always, even if the provided BlobInfo is equivalent to a previously created one. Allocate a UUID, and hash it with goodFastHash(64) before encoding to base64 (url safe).
BenWhitehead
force-pushed
the
write-acceleration/m2/4/remove-collision
branch
from
495dcc3 to
ab81e77
Compare
|
Warning: This pull request is touching the following templated files:
|
BenWhitehead
force-pushed
the
write-acceleration/m2/3journaling-bwsc-property-tests
branch
from
4e591a9 to
e09d0a0
Compare
BenWhitehead
changed the base branch from
write-acceleration/m2/3journaling-bwsc-property-tests
to
main
BenWhitehead
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sydney-munro
approved these changes
Sep 25, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
🤖 I have created a release *beep* *boop* --- ## [2.27.1](https://togithub.com/googleapis/java-storage/compare/v2.27.0...v2.27.1) (2023-09-25) ### Bug Fixes * Consider Storage#delete(BlobId) idempotent when id has generation ([#2222](https://togithub.com/googleapis/java-storage/issues/2222)) ([453dd63](https://togithub.com/googleapis/java-storage/commit/453dd63e63d899197b25b58452c08fa0b41f75b0)) * Update RecoveryFileManager to allow distinct files for multiple invocations of equivalent info ([#2207](https://togithub.com/googleapis/java-storage/issues/2207)) ([44e9dd5](https://togithub.com/googleapis/java-storage/commit/44e9dd558bb979f0c7607ad24f07e6d03a641c66)) ### Dependencies * Update dependency com.google.apis:google-api-services-storage to v1-rev20230914-2.0.0 ([#2213](https://togithub.com/googleapis/java-storage/issues/2213)) ([0af39d6](https://togithub.com/googleapis/java-storage/commit/0af39d6be333dd6993785491f14e1bd8942573ea)) * Update dependency com.google.apis:google-api-services-storage to v1-rev20230922-2.0.0 ([#2223](https://togithub.com/googleapis/java-storage/issues/2223)) ([844fe80](https://togithub.com/googleapis/java-storage/commit/844fe803af925c7501910a5ea89f9ddadc18b5b9)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.16.0 ([#2219](https://togithub.com/googleapis/java-storage/issues/2219)) ([7401f21](https://togithub.com/googleapis/java-storage/commit/7401f2173f60f34506d5d65396b3baadd52de5cc)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.16.1 ([#2225](https://togithub.com/googleapis/java-storage/issues/2225)) ([f092c4e](https://togithub.com/googleapis/java-storage/commit/f092c4ebbbbf378511c6e1d663c4656dc03a0724)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.27 ([#2210](https://togithub.com/googleapis/java-storage/issues/2210)) ([3c77530](https://togithub.com/googleapis/java-storage/commit/3c77530392dac2eca04585506e839d3215d44f0c)) * Update gapic-generator-java to 2.26.0 ([#2224](https://togithub.com/googleapis/java-storage/issues/2224)) ([a105736](https://togithub.com/googleapis/java-storage/commit/a105736535429418740e8e8d72e92e5c705575f1)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new recovery file it is important that distinct recovery files be created always, even if the provided BlobInfo is equivalent to a previously created one.
Allocate a UUID, and hash it with goodFastHash(64) before encoding to base64 (url safe).
Follow up to #2195 todo