fix: implementations of FromHexString() for md5 and crc32c #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
frankyn
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
JesseLovelace
approved these changes
Apr 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
============================================
+ Coverage 63.50% 63.52% +0.02%
Complexity 540 540
============================================
Files 30 30
Lines 4762 4776 +14
Branches 427 431 +4
============================================
+ Hits 3024 3034 +10
- Misses 1578 1580 +2
- Partials 160 162 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FromHexString() helpers don't handle leading zeros correctly. Added tests and provided a new implementation.