KEMBAR78
fix: Improve projectId handling in authentication by thiyaguk09 · Pull Request #2584 · googleapis/nodejs-storage · GitHub
Skip to content

Conversation

@thiyaguk09
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

thiyaguk09 and others added 11 commits December 20, 2024 10:17
…ckets (googleapis#2566)

* Adds support for the restore token feature

* description fix

* lint fix

* fetch softDeleted bucket list & details

fetch softDeleted bucket list & details

* initial commit for bucket restore

initial commit for bucket restore

* fix missing license headers

fix missing license headers

* lint fix

* test case bug fix

* added restore bucket unit test cases

* added restore bucket system test

added restore bucket system test

* lint fix

* format

format

* system test fix
* chore(main): release 7.15.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore: fix type errors in build

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix docs links

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* Set CODEOWNERS as gcs-sdk-team

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* update repo metadata with new team

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix broken types causing compilation failures

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>
Improve projectId handling in authentication and resolve issue in patch
request
@thiyaguk09 thiyaguk09 requested a review from a team as a code owner March 13, 2025 11:06
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/CODEOWNERS - CODEOWNERS should instead be modified via the codeowner_team property in .repo-metadata.json

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/nodejs-storage API. labels Mar 13, 2025
@thiyaguk09 thiyaguk09 marked this pull request as draft March 13, 2025 11:26
@thiyaguk09 thiyaguk09 marked this pull request as ready for review March 13, 2025 12:00
@ddelgrosso1 ddelgrosso1 merged commit 6d94e45 into googleapis:node-18 Mar 13, 2025
12 checks passed
thiyaguk09 added a commit to thiyaguk09/nodejs-storage-fork that referenced this pull request May 2, 2025
* feat: add ability to configure and utilize soft-delete and restore buckets (googleapis#2566)

* Adds support for the restore token feature

* description fix

* lint fix

* fetch softDeleted bucket list & details

fetch softDeleted bucket list & details

* initial commit for bucket restore

initial commit for bucket restore

* fix missing license headers

fix missing license headers

* lint fix

* test case bug fix

* added restore bucket unit test cases

* added restore bucket system test

added restore bucket system test

* lint fix

* format

format

* system test fix

* chore(main): release 7.15.0 (googleapis#2568)

* chore(main): release 7.15.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: replace reference docs link with RAD (googleapis#2571)

* fix(getFiles): add nextPageToken to fields for autoPaginate (googleapis#2570)

* chore: fix type errors in build (googleapis#2577)

* chore: fix type errors in build

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix docs links

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 7.15.1 (googleapis#2573)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix: export SaveData type from index.ts (googleapis#2580)

* chore(main): release 7.15.2 (googleapis#2581)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: set gcs-sdk-team as CODEOWNERS  (googleapis#2582)

* Set CODEOWNERS as gcs-sdk-team

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* update repo metadata with new team

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix broken types causing compilation failures

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>

* fix: Improve projectId handling in authentication

Improve projectId handling in authentication and resolve issue in patch
request

* bug fix

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Daniel B <danielduhh@gmail.com>
Co-authored-by: Jarrett <2613089+jjaareet@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>
Co-authored-by: David Stensland <me@terite.com>
Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants