KEMBAR78
chore: refactor cell data parsing to use classes for easier overrides by tswast · Pull Request #2144 · googleapis/python-bigquery · GitHub
Skip to content

chore: refactor cell data parsing to use classes for easier overrides #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 19, 2025
Merged

chore: refactor cell data parsing to use classes for easier overrides #2144

merged 6 commits into from
Mar 19, 2025

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Mar 11, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #1876
🦕

@tswast tswast requested review from a team as code owners March 11, 2025 21:43
@tswast tswast requested a review from mrfaizal March 11, 2025 21:43
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery API. labels Mar 11, 2025
@tswast tswast requested review from Linchin and chalmerlowe and removed request for mrfaizal March 11, 2025 21:43
@tswast tswast mentioned this pull request Mar 11, 2025
Merged
6 tasks
chalmerlowe
chalmerlowe reviewed Mar 18, 2025
View reviewed changes
chalmerlowe
chalmerlowe reviewed Mar 19, 2025
View reviewed changes
chalmerlowe
chalmerlowe approved these changes Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question about boilerplate copyright text.

That is not a show stopper.

It looks like coverage is grumbly about one of the lines in _helpers.py. Once that gets cleaned up, we should be good to go.

Gonna approve this.

@tswast tswast merged commit 9acd9c1 into main Mar 19, 2025
18 checks passed
@tswast tswast deleted the tswast-refactor-cell-data branch March 19, 2025 15:17
chalmerlowe pushed a commit that referenced this pull request Mar 25, 2025
@tswast @chalmerlowe
chore: refactor cell data parsing to use classes for easier overrides (…
df4d12b 
…#2144)

* chore: refactor cell data parsing to use classes for easier overrides

* improve error messages with urls for valueerrors

* Update tests/unit/_helpers/test_cell_data_parser.py

* remove unreachable code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@Linchin Linchin Awaiting requested review from Linchin

+1 more reviewer

@GarrettWu GarrettWu GarrettWu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shollyman shollyman

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tswast @GarrettWu @chalmerlowe @shollyman