KEMBAR78
Feat: download_to_filename deletes the empty file on a 404 by andrewsg · Pull Request #1394 · googleapis/python-storage · GitHub
Skip to content

Feat: download_to_filename deletes the empty file on a 404 #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2024
Merged

Feat: download_to_filename deletes the empty file on a 404 #1394

merged 1 commit into from
Dec 11, 2024
+47 −2

Conversation

@andrewsg
Copy link
Contributor

@andrewsg andrewsg commented Dec 11, 2024 •
edited
Loading

Fixes #1342 🦕

BEGIN_COMMIT_OVERRIDE
feat!: Blob.download_to_filename() deletes the empty destination file on a 404
END_COMMIT_OVERRIDE

@andrewsg andrewsg requested review from a team as code owners December 11, 2024 16:58
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Dec 11, 2024
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Dec 11, 2024
ddelgrosso1
ddelgrosso1 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewsg andrewsg merged commit 066be2d into main Dec 11, 2024
13 checks passed
@andrewsg andrewsg deleted the 3.0-filename-404-cleanup branch December 11, 2024 18:11
@release-please release-please bot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees

@cojenco cojenco

Labels

api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Blob.download_to_filename leaves empty file if not found

3 participants

@andrewsg @ddelgrosso1 @cojenco