feat: added BitmapDescriptor as parameter to AdvancedMarker #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
|
dkhawk
reviewed
Jul 11, 2025
| } | ||
| update(pinConfig) { | ||
| if (iconView == null) { | ||
| if (icon == null && iconView == null) { |
There was a problem hiding this comment.
Is this correct? Do you need the icon to be set to proceed? I am not sure about this code.
There was a problem hiding this comment.
In order of priority we set the iconView, then the pinConfig and then the icon. This is to cover the case where many parameters are set at once.
I have added a comment to clarify this.
dkhawk
reviewed
Jul 14, 2025
| // 3. If neither iconView nor pinConfig are available, fall back to the raw icon. | ||
|
|
||
| if (iconView != null) { | ||
| advancedMarkerOptions.iconView(iconView) |
There was a problem hiding this comment.
Nit: these multibranch conditionals typically read better as a when statement
dkhawk
approved these changes
Jul 14, 2025
googlemaps-bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
# [6.7.0](v6.6.0...v6.7.0) (2025-07-14) ### Features * added BitmapDescriptor as parameter to AdvancedMarker ([#718](#718)) ([e1c2277](e1c2277))
|
🎉 This PR is included in version 6.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR adds a new parameter BitmapDescriptor to the AdvancedMarker. The AdvancedMarker has, as an addition to the Marker, the possibility to set up an iconView, a pinConfig and/or the CollisionBehavior. It could be that users only want to control the CollisionBehavior, so this interface could be useful.
Fixes #708 🦕